fix: Address comments

Signed-off-by: Ce Gao <gaoce@caicloud.io>
kubeflow · May 18, 2019 · db7dba7 · db7dba7
1 parent 0464604
commit db7dba7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/scripts/v1alpha1/build.sh b/scripts/v1alpha1/build.sh
@@ -40,7 +40,7 @@ docker build -t ${PREFIX}/v1alpha1/suggestion-grid -f ${CMD_PREFIX}/suggestion/g
 docker build -t ${PREFIX}/v1alpha1/suggestion-hyperband -f ${CMD_PREFIX}/suggestion/hyperband/v1alpha1/Dockerfile .
 docker build -t ${PREFIX}/v1alpha1/suggestion-bayesianoptimization -f ${CMD_PREFIX}/suggestion/bayesianoptimization/v1alpha1/Dockerfile .
 docker build -t ${PREFIX}/v1alpha1/suggestion-nasrl -f ${CMD_PREFIX}/suggestion/nasrl/v1alpha1/Dockerfile .
-docker build -t ${PREFIX}/suggestion-nasenvelopenet -f ${CMD_PREFIX}/suggestion/nasenvelopenet/v1alpha1/Dockerfile .
+docker build -t ${PREFIX}/v1alpha1/suggestion-nasenvelopenet -f ${CMD_PREFIX}/suggestion/nasenvelopenet/v1alpha1/Dockerfile .
 
 echo "Building earlystopping images..."
 docker build -t ${PREFIX}/v1alpha1/earlystopping-medianstopping -f ${CMD_PREFIX}/earlystopping/medianstopping/v1alpha1/Dockerfile .

diff --git a/test/scripts/v1alpha1/build-suggestion-nasenvelopenet.sh b/test/scripts/v1alpha1/build-suggestion-nasenvelopenet.sh
@@ -39,4 +39,4 @@ cd ${GO_DIR}
 
 cp cmd/suggestion/nasenvelopenet/Dockerfile .
 gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} --project=${PROJECT}
-gcloud container images add-tag --quiet ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:latest --verbosity=info
+gcloud container images add-tag --quiet ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} ${REGISTRY}/${REPO_NAME}/v1alpha1/suggestion-nasenvelopenet:latest --verbosity=info
diff --git a/test/scripts/v1alpha2/build-suggestion-nasenvelopenet.sh b/test/scripts/v1alpha2/build-suggestion-nasenvelopenet.sh
@@ -16,6 +16,8 @@
 
 # This shell script is used to build an image from our argo workflow
 
+exit 0
+
 set -o errexit
 set -o nounset
 set -o pipefail
@@ -39,4 +41,4 @@ cd ${GO_DIR}
 
 cp cmd/suggestion/nasenvelopenet/Dockerfile .
 gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} --project=${PROJECT}
-gcloud container images add-tag --quiet ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:latest --verbosity=info
+gcloud container images add-tag --quiet ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} ${REGISTRY}/${REPO_NAME}/v1alpha2/suggestion-nasenvelopenet:latest --verbosity=info