fix: Fix experiment test

Signed-off-by: Ce Gao <gaoce@caicloud.io>
kubeflow · Jun 12, 2019 · 5252048 · 5252048
1 parent 7143b05
commit 5252048
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pkg/controller/v1alpha2/experiment/experiment_controller_test.go b/pkg/controller/v1alpha2/experiment/experiment_controller_test.go
@@ -31,7 +31,7 @@ const (
 	experimentName = "foo"
 	namespace      = "default"
 
-	timeout = time.Second * 5
+	timeout = time.Second * 20
 )
 
 var expectedRequest = reconcile.Request{NamespacedName: types.NamespacedName{Name: experimentName, Namespace: namespace}}
@@ -89,7 +89,7 @@ func TestCreateExperiment(t *testing.T) {
 	}()
 
 	stopCh := make(chan struct{})
-	mgr.GetCache().WaitForCacheSync(stopCh)
+	g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue())
 	defer func() {
 		close(stopCh)
 	}()

diff --git a/pkg/controller/v1alpha2/trial/trial_controller_test.go b/pkg/controller/v1alpha2/trial/trial_controller_test.go
@@ -126,6 +126,12 @@ func TestReconcileTFJobTrial(t *testing.T) {
 
 	stopMgr, mgrStopped := StartTestManager(mgr, g)
 
+	stopCh := make(chan struct{})
+	g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue())
+	defer func() {
+		close(stopCh)
+	}()
+
 	defer func() {
 		close(stopMgr)
 		mgrStopped.Wait()