-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update org.yaml to be added as a member of pipeline team #70
Conversation
Seems i need to be in the pipeline members team to be able to review and approve PRs
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @animeshsingh. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Why do you think that? Reviewing and approving PRs should be based on OWNERs files as described in the contributing guide. |
Well it has been a constant issue there. Even though OWNERS file has that listed in sub-directory its going to the top level OWNERS file. |
@animeshsingh Can you give me a specific example of a PR where an approver in a sub file was not able to approve something? Putting someone in the OWNERs file has no effect if they aren't in the org. If you want to expediate this I'd suggest removing yourself from the pipelines team so we can get you added to the org and we can go from there. |
Thanks - getting added to the org would be best. What do I need for that? @jlewi |
btw this was the last one where we had issues and many like this. Lets start with being added to the org, and then we can take forward from there |
Add yourself to the org here:
Just add yourself as a member of the org not as a member of any teams. Please insert yourself in alphabetical order. |
i am already there @jlewi
But I dont see myself listed when I go to |
The permissions need to be manually sync'd. Closing this PR because it shouldn't be necessary. |
Seems i need to be in the pipeline members team to be able to review and approve PRs
This change is