Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.yaml to be added as a member of pipeline team #70

Closed
wants to merge 1 commit into from

Conversation

animeshsingh
Copy link
Contributor

@animeshsingh animeshsingh commented Mar 7, 2019

Seems i need to be in the pipeline members team to be able to review and approve PRs


This change is Reviewable

Seems i need to be in the pipeline members team to be able to review and approve PRs
@k8s-ci-robot k8s-ci-robot requested review from jlewi and theadactyl March 7, 2019 06:53
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: theadactyl

If they are not already assigned, you can assign the PR to them by writing /assign @theadactyl in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @animeshsingh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi
Copy link
Contributor

jlewi commented Mar 7, 2019

Why do you think that? Reviewing and approving PRs should be based on OWNERs files as described in the contributing guide.

@animeshsingh
Copy link
Contributor Author

Well it has been a constant issue there. Even though OWNERS file has that listed in sub-directory its going to the top level OWNERS file.

@jlewi
Copy link
Contributor

jlewi commented Mar 8, 2019

@animeshsingh Can you give me a specific example of a PR where an approver in a sub file was not able to approve something?

Putting someone in the OWNERs file has no effect if they aren't in the org.

If you want to expediate this I'd suggest removing yourself from the pipelines team so we can get you added to the org and we can go from there.

@animeshsingh
Copy link
Contributor Author

animeshsingh commented Mar 8, 2019

Thanks - getting added to the org would be best. What do I need for that? @jlewi

@animeshsingh
Copy link
Contributor Author

btw this was the last one where we had issues
kubeflow/pipelines#915 (comment)

and many like this. Lets start with being added to the org, and then we can take forward from there

@jlewi
Copy link
Contributor

jlewi commented Mar 9, 2019

Add yourself to the org here:

Just add yourself as a member of the org not as a member of any teams.

Please insert yourself in alphabetical order.

@animeshsingh
Copy link
Contributor Author

animeshsingh commented Mar 9, 2019

i am already there @jlewi

But I dont see myself listed when I go to
https://github.com/orgs/kubeflow/people

@jlewi
Copy link
Contributor

jlewi commented Mar 10, 2019

The permissions need to be manually sync'd.
I just sync'd them.. So check your email for an invitation from GitHub to join the org and accept it.

Closing this PR because it shouldn't be necessary.

@jlewi jlewi closed this Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants