Skip to content
This repository was archived by the owner on Dec 2, 2021. It is now read-only.

Commit

Permalink
[MLMD][BugBash] Make card titles link to resource details pages (#22)
Browse files Browse the repository at this point in the history
* First pass of adding navigation to Lineage card titles.

* Pass up typeName and add support for navigation to Execution details

Fixes issue where the initial artifact's type was used for all navigation.

It is known that browser back doesn't go back to the LineageExplorer tab.
This will be fixed by kubeflow/metadata#149.

* Add react-router-dom as a dependency

* Switch to react-router-dom v4 to stay in sync with kubeflow verticals

* Refactor logic to build routes at the earliest point

* Revert unused interface change
  • Loading branch information
kwasi authored and k8s-ci-robot committed Jan 27, 2020
1 parent 1894c30 commit 963164a
Show file tree
Hide file tree
Showing 14 changed files with 129 additions and 26 deletions.
2 changes: 1 addition & 1 deletion build/lib/mlmd/LineageCard.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/lib/mlmd/LineageCard.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions build/lib/mlmd/LineageCardRow.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/lib/mlmd/LineageCardRow.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/lib/mlmd/LineageTypes.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions build/lib/mlmd/LineageView.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 963164a

Please sign in to comment.