Fix missing ActionBar breadcrumbs (#42)

kubeflow · Feb 12, 2020 · 2a39c3f · 2a39c3f
1 parent 29b7f91
commit 2a39c3f
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 51 deletions.
diff --git a/build/lib/mlmd/LineageActionBar.js b/build/lib/mlmd/LineageActionBar.js
diff --git a/build/lib/mlmd/LineageActionBar.js.map b/build/lib/mlmd/LineageActionBar.js.map
diff --git a/build/lib/mlmd/Utils.js b/build/lib/mlmd/Utils.js
diff --git a/build/lib/mlmd/Utils.js.map b/build/lib/mlmd/Utils.js.map
diff --git a/src/mlmd/LineageActionBar.tsx b/src/mlmd/LineageActionBar.tsx
@@ -6,7 +6,10 @@ import ReplayIcon from '@material-ui/icons/Replay';
 import {classes, stylesheet} from "typestyle";
 import {color, commonCss, fonts, padding} from "./Css";
 import {CSSProperties} from "typestyle/lib/types";
-import {getResourceProperty, getResourcePropertyViaFallBack} from "./Utils";
+import {
+    getArtifactName,
+    getResourcePropertyViaFallBack,
+} from './Utils';
 import {Artifact} from '..';
 import {ArtifactProperties, ArtifactCustomProperties} from "./Api";
 
@@ -134,10 +137,7 @@ export class LineageActionBar extends React.Component<LineageActionBarProps, Lin
                 disabled={isActive}
                 onClick={onBreadcrumbClicked}
               >
-                  {
-                      // TODO: Resolve how to handle Artifacts logged with no name
-                      getResourceProperty(artifact, ArtifactProperties.NAME) || '(unnamed)'
-                  }
+                  {getArtifactName(artifact)}
               </button>
             );
             if (!isActive) {