Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xgboost_synthetic test #676

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Nov 6, 2019

Fix miscellaneous bugs with the xgboost_synthetic test


This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Nov 6, 2019

/test all

* namespace where test runs should correspond to the namespace of a Kubeflow
  profile

* There was a bug in the logging format string

* There was a bug in the print statement for the job
@jlewi jlewi changed the title [WIP] Try with updated credentials. Try with updated credentials. Nov 6, 2019
@jlewi jlewi marked this pull request as ready for review November 6, 2019 20:41
@jlewi jlewi changed the title Try with updated credentials. Fix xgboost_synthetic test Nov 6, 2019
@jlewi
Copy link
Contributor Author

jlewi commented Nov 6, 2019

/assign @kunmingg

@kunmingg
Copy link
Contributor

kunmingg commented Nov 8, 2019

/lgtm
/approve

@jlewi
Copy link
Contributor Author

jlewi commented Nov 8, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7a2977e into kubeflow:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants