Fix the xgboost_synthetic test so it actually runs and produces signal #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The test wasn't actually running because we were passing arguments that were unknown to pytest * Remove the old role.yaml; we don't use it anymore * Wait for the Job to finish and properly report status; kubeflow/testing#514 contains the new routine * The test still isn't passing because of kubeflow#673 * In addition we need to fix the auto deployments kubeflow/testing#444 Related to kubeflow#665
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jinchihe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test wasn't actually running because we were passing arguments that
were unknown to pytest
Remove the old role.yaml; we don't use it anymore
Wait for the Job to finish and properly report status; Add a utility routine to wait for a batch job to finish. testing#514
contains the new routine
The test still isn't passing because of xgboost_synthetic in 0.7.0 model doesn't deploy #673
In addition we need to fix the auto deployments Auto-deployments of Kubeflow should use unique names and not recycle names - Upgrade to v0.7 testing#444
Related to #665
This change is