Change dataflow default workdir to /src #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise when I want to execute dataflow code ``` python2 -m code_search.dataflow.cli.create_function_embeddings \ ``` it complains no setup.py I could workaround by using workingdir container API but setting it to default would be more convenient.
|
In addition, this would be very useful for resuing the image to build a kf pipeline. See limitation of current pipeline. |
|
/assign @jlewi |
|
FYI; You can also set the workdir in the command. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yixinshi
pushed a commit
to yixinshi/examples
that referenced
this pull request
Nov 30, 2018
Otherwise when I want to execute dataflow code ``` python2 -m code_search.dataflow.cli.create_function_embeddings \ ``` it complains no setup.py I could workaround by using workingdir container API but setting it to default would be more convenient.
Svendegroote91
pushed a commit
to Svendegroote91/examples
that referenced
this pull request
Dec 6, 2018
Otherwise when I want to execute dataflow code ``` python2 -m code_search.dataflow.cli.create_function_embeddings \ ``` it complains no setup.py I could workaround by using workingdir container API but setting it to default would be more convenient.
Svendegroote91
pushed a commit
to Svendegroote91/examples
that referenced
this pull request
Apr 1, 2019
Otherwise when I want to execute dataflow code ``` python2 -m code_search.dataflow.cli.create_function_embeddings \ ``` it complains no setup.py I could workaround by using workingdir container API but setting it to default would be more convenient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise when I want to execute dataflow code
it complains no setup.py
I could workaround by using workingdir option to switch the dir when launching the container, but setting it to default would be more convenient.
This change is