Add common types to kubeflow/common #2
Conversation
|
/assign @johnugeorge |
|
@terrytangyuan: changing LGTM is restricted to assignees, and assigning you to the PR failed. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
operator/v1/types.go
Outdated
| CleanPodPolicy *CleanPodPolicy `json:"cleanPodPolicy,omitempty"` | ||
|
|
||
| // TTLSecondsAfterFinished is the TTL to clean up jobs (temporary | ||
| // before kubernetes adds the cleanup controller). |
There was a problem hiding this comment.
One nit, we can probably remove this comments now: temporary before kubernetes adds the cleanup controller now.
since the kubernetes has already added this
| // RunPolicy encapsulates various runtime policies of the distributed training | ||
| // job, for example how to clean up resources and how long the job can stay | ||
| // active. | ||
| type RunPolicy struct { |
There was a problem hiding this comment.
I'm up for the idea of a new RunPolicy. One question: Once TFJob spec start to use this RunPolicy, it'll break the API compatibility. Is this the expectation ?
There was a problem hiding this comment.
The plan is to introduce another API version on TFJob. The current version (v1beta2) will not use this repo.
Also we added support for multiple CRD versions in v0.5, We can also investigate how to use conversion webhooks for API compatibility: kubernetes/enhancements#598. But looks like this feature requires k8s 1.15.
|
/lgtm |
|
@jian-he: changing LGTM is restricted to assignees, and assigning you to the PR failed. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
1 similar comment
|
/lgtm |
* - added nudging message for old CEP PS plugin * Update requirements.in * Update requirements.in * Update requirements.in Co-authored-by: Andreas Braumann <brew@brew.at> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexander Graf <alex@basecamp.tirol>
Part 1 of kubeflow/training-operator#960
This change is