-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolved mobile responsive bug (#673) #674
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @harshita9104! It looks like this is your first PR to kubeedge/website 🎉 |
Signed-off-by: harshita91 <roonwal721972@gmail.com>
44efabf
to
58b5f42
Compare
/assign @kevin-wangzefeng |
Hello @kevin-wangzefeng , @anvithks , @edisonxiang , Kindly review the PR if any modifications are required please let me know!! Thank you! |
Hello @Shelley-BaoYue , |
/assign @Shelley-BaoYue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Thanks for your contributions!
/lgtm
// } | ||
// } | ||
|
||
// html[data-theme='dark'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why comments are pushed? @harshita9104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will remove them thanks for review!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my pleasure
Which issue(s) this PR fixes:
Fixes #673
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
What is the new behavior (if this is a feature change)?
max-width: 100%
.Does this PR introduce a breaking change?
No, this PR does not introduce breaking changes.
Screenshots of the changes made
![Screenshot 2025-02-04 143041](https://private-user-images.githubusercontent.com/137335511/409487191-5fa81e8c-1af9-49cd-a7d7-0398118e67f2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTAzNDMsIm5iZiI6MTczOTM5MDA0MywicGF0aCI6Ii8xMzczMzU1MTEvNDA5NDg3MTkxLTVmYTgxZThjLTFhZjktNDljZC1hN2Q3LTAzOTgxMThlNjdmMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQxOTU0MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jY2QzY2ZhZDZhNGYxOTVkOTVlNjc3MjY0N2U1MzhlNWJkNzUwOWI0YjA3OTQ3Nzc5MDFjMzVkOTVhNzNhNzNmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.y7u7qjLtW3Vja-08k9CqnQ2p8no9pqa2GfEpp4pJmiQ)
![Screenshot 2025-02-04 143102](https://private-user-images.githubusercontent.com/137335511/409487229-f6158c7e-bd53-48f0-81cb-f73be3b7f1a6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTAzNDMsIm5iZiI6MTczOTM5MDA0MywicGF0aCI6Ii8xMzczMzU1MTEvNDA5NDg3MjI5LWY2MTU4YzdlLWJkNTMtNDhmMC04MWNiLWY3M2JlM2I3ZjFhNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQxOTU0MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wN2EwZGM5OWM3ZjlmMmRiNjBkMDlmYjg5NjgxNjE5Y2UwMWQ5MjUxZDdjODdjNTA3N2FlMDI1MzQ2Yjk1N2JiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.p-IVfJyPCF3rYvNVzP1GNi2_8FVDupXZOF3wsUBMK_c)
![Screenshot 2025-02-04 143117](https://private-user-images.githubusercontent.com/137335511/409487246-e5b14f06-7964-4537-a49e-9ff1fad7332a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTAzNDMsIm5iZiI6MTczOTM5MDA0MywicGF0aCI6Ii8xMzczMzU1MTEvNDA5NDg3MjQ2LWU1YjE0ZjA2LTc5NjQtNDUzNy1hNDllLTlmZjFmYWQ3MzMyYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQxOTU0MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNWE4MWI4NmQ0ZjA2NGQyNzFiNjU5MmEyMzAwMjBmYjBhZmZmMDhjMzU2ZmI1ZWIxNTI1NmU1ZjNmMzliODljJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.urdqu-TdFnOz-maL3tCHAavzx7GAzEdOAxvtfNGWlW8)
Additional Notes: