Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved mobile responsive bug (#673) #674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harshita9104
Copy link

Which issue(s) this PR fixes:

Fixes #673

  • What kind of change does this PR introduce?
    Bug fix

  • What is the current behavior?

    • The tag toggle container overflows its parent container on smaller screens.
    • The case study text is too large, causing misalignment and layout issues.
    • The "POST YOUR CASE" button does not fit properly in its container.
  • What is the new behavior (if this is a feature change)?

    • Ensured the tag toggle container stays within its parent using max-width: 100%.
    • Adjusted case study text sizes to fit within their containers.
    • Properly positioned the "POST YOUR CASE" button to prevent overflow.
    • Improved mobile responsiveness for better usability across different screen sizes.
  • Does this PR introduce a breaking change?
    No, this PR does not introduce breaking changes.

  • Screenshots of the changes made
    Screenshot 2025-02-04 143041
    Screenshot 2025-02-04 143102
    Screenshot 2025-02-04 143117

Additional Notes:

  • This PR improves UI responsiveness and fixes layout issues in the Case Studies page.
  • All changes have been tested on desktop, tablet, and mobile devices to ensure proper rendering.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot
Copy link
Collaborator

Welcome @harshita9104! It looks like this is your first PR to kubeedge/website 🎉

@kubeedge-bot kubeedge-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 4, 2025
Signed-off-by: harshita91 <roonwal721972@gmail.com>
@harshita9104
Copy link
Author

/assign @kevin-wangzefeng

@harshita9104
Copy link
Author

Hello @kevin-wangzefeng , @anvithks , @edisonxiang ,

Kindly review the PR if any modifications are required please let me know!!

Thank you!

@harshita9104
Copy link
Author

Hello @Shelley-BaoYue ,
I am harshita roonwal , CS undergraduate from India , I am actively contributing to Kubeedge website and I am planning to take part in LFX mentorship term 1 2025 .
I have 3+ years of experience in Javascript, website development and dealing with APIs, and I have worked with Atlan as Technical Consulting writer , I have opened few potential issues in Kubeedge website, and I am working on those issues currently.
Please review this PR: #674
/kind bug
This PR fixes a mobile responsiveness bug in the Case Studies page, ensuring that UI elements such as the "POST YOUR CASE" button, case study titles, and tag toggles are properly aligned and do not overflow their containers. The update enhances the overall layout, making it fully responsive across different screen sizes.
Fixes #673
Special notes for the reviewer:
Please verify the UI changes on both mobile and tablet views to ensure proper alignment.
Confirm that text elements wrap correctly without being cut off.
Ensure the tag toggle section adjusts properly on smaller screens.
Does this PR introduce a user-facing change?
NONE
Labels: kind/bug, size/XL

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 10, 2025
@harshita9104
Copy link
Author

/assign @Shelley-BaoYue

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Thanks for your contributions!
/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
// }
// }

// html[data-theme='dark'] {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why comments are pushed? @harshita9104

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will remove them thanks for review!!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Overflow and Button Overlap in Mobile View on Case Study Page
5 participants