Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device crd, mapper, mapper-framework docs #439

Merged
merged 1 commit into from
May 9, 2024
Merged

Add device crd, mapper, mapper-framework docs #439

merged 1 commit into from
May 9, 2024

Conversation

wbc6080
Copy link
Contributor

@wbc6080 wbc6080 commented Oct 28, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    update dmi and mapper-framework docs, introduce v1beta1 device API

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 28, 2023
@wbc6080 wbc6080 changed the title update mapper docs [WIP]update mapper docs Nov 1, 2023
@kubeedge-bot kubeedge-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
@wbc6080 wbc6080 changed the title [WIP]update mapper docs update mapper docs Nov 3, 2023
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@cl2017
Copy link

cl2017 commented Nov 28, 2023

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@wbc6080 wbc6080 force-pushed the add-mapper-docs branch 3 times, most recently from b630aa1 to aa2c16f Compare February 1, 2024 03:21
@wbc6080 wbc6080 changed the title update mapper docs Add device crd, mapper, mapper-framework docs Feb 1, 2024
@wbc6080 wbc6080 mentioned this pull request Feb 1, 2024
Closed
3 tasks
@WillardHu
Copy link
Contributor

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@wbc6080
Copy link
Contributor Author

wbc6080 commented Feb 1, 2024

cc @Shelley-BaoYue @fisherxu thanks

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@wbc6080
update mapper docs
66a39bd 
Signed-off-by: wbc6080 <wangbincheng4@huawei.com>
@wbc6080 wbc6080 force-pushed the add-mapper-docs branch from 5b79868 to 66a39bd Compare May 9, 2024 08:25
@kubeedge-bot kubeedge-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
This was referenced May 9, 2024
Closed
Closed
Closed
fisherxu
fisherxu reviewed May 9, 2024
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@kubeedge-bot kubeedge-bot merged commit 8814a85 into kubeedge:master May 9, 2024
6 checks passed
@wbc6080 wbc6080 deleted the add-mapper-docs branch May 10, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@edisonxiang edisonxiang Awaiting requested review from edisonxiang

Assignees

@WillardHu WillardHu

@cl2017 cl2017

@fisherxu fisherxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wbc6080 @cl2017 @WillardHu @kubeedge-bot @fisherxu