Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edge node auto register #1401

Merged
merged 3 commits into from
Jan 21, 2020
Merged

edge node auto register #1401

merged 3 commits into from
Jan 21, 2020

Conversation

kuramal
Copy link
Contributor

@kuramal kuramal commented Jan 15, 2020 •
edited
Loading

What type of PR is this?

/kind documentation
/kind feature

What this PR does / why we need it:
support edge node auto register

Which issue(s) this PR fixes:
Fixes #881

Does this PR introduce a user-facing change?:

Edge node auto register
Now the edge node will automatically register by default,  If you want register manually, you should set the config register-node of edged with false

@kubeedge-bot kubeedge-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2020
@kevin-wangzefeng
Copy link
Member

kevin-wangzefeng commented Jan 15, 2020 •
edited
Loading

Please add release-note section in PR description

kadisi
kadisi reviewed Jan 16, 2020
View reviewed changes
@kuramal kuramal force-pushed the node-auto-regist branch 3 times, most recently from a22da2d to e91b4f4 Compare January 17, 2020 01:17
@kuramal
auto register edge node to k8s
bce0e29 
Signed-off-by: Su Xiaolin <linxxnil@126.com>
@kuramal
update docs about edge node auto register
5e1b290 
optimize some code

Signed-off-by: Su Xiaolin <linxxnil@126.com>
@kuramal
Copy link
Contributor Author

kuramal commented Jan 20, 2020

@fisherxu @kadisi update with new config api, PTAL

fisherxu
fisherxu reviewed Jan 21, 2020
View reviewed changes
docs/setup/deploy-edge-node.md
@@ -0,0 +1,43 @@
# Deploy Edge Node Manually
Copy link
Member

@fisherxu fisherxu Jan 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to jump here from setup.md? I'd suggest to keep it in setup.md. For example:

Deploy the edge node

Edge node can be registered automatically.

Deploy Edge Node Manually

If you want to deploy edge node manually, here is an example.

Maybe we need reminder users to set register-node to false here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please help modify it more clear，like: L5-L16, we can just delete it.

@kuramal kuramal force-pushed the node-auto-regist branch 2 times, most recently from ace40e5 to 5848488 Compare January 21, 2020 09:36
@kuramal
set edge node auto register to optional, and update docs
5848488 
Signed-off-by: Su Xiaolin <linxxnil@126.com>
@fisherxu
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@kevin-wangzefeng
Copy link
Member

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@kubeedge-bot kubeedge-bot merged commit 19dcd2d into kubeedge:master Jan 21, 2020
@fisherxu fisherxu mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@fisherxu fisherxu fisherxu left review comments

@kadisi kadisi kadisi left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create and register node from edge part
5 participants
@kuramal @kevin-wangzefeng @fisherxu @kubeedge-bot @kadisi