Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Solve the problem of outputting a large amount of logs after edgecore exits #1223

Merged
merged 9 commits into from
Nov 13, 2019
Merged

bugfix: Solve the problem of outputting a large amount of logs after edgecore exits #1223

merged 9 commits into from
Nov 13, 2019

Conversation

kadisi
Copy link
Member

@kadisi kadisi commented Oct 23, 2019 •
edited by kevin-wangzefeng
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature

/kind bug
What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Bugfix: Remove redundant logs when EdgeCore exits

@kubeedge-bot kubeedge-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 23, 2019
@kadisi kadisi force-pushed the edgecore_stop_channel branch from 4bd5ffd to dc3a9f0 Compare October 23, 2019 07:24
@kadisi kadisi mentioned this pull request Oct 23, 2019
Closed
25 tasks
@kadisi kadisi force-pushed the edgecore_stop_channel branch from dc3a9f0 to e29bb0b Compare October 23, 2019 08:16
@kevin-wangzefeng
Copy link
Member

Revised release note to: "Bugfix: Remove redundant logs when EdgeCore exits"
Let me know when it's ready for final review.

@kadisi
move DTController to DeviceTwin struct
12ca513 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi
edevicetwin uses the golang context instead of the stop channel.
220e8dc 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi
edged: uses the golang context instead of the stop channel.
aec536b 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi
move Controller to EdgeHub struct
d024894 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi
edgehub:uses the golang context instead of the stop channel
dac9d7c 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi
eventbus:uses the golang context instead of the stop channel
09b51a8 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi
edgemesh:uses the golang context instead of the stop channel
ebf525b 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi
metamanager:uses the golang context instead of the stop channel
b2e92da 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi kadisi force-pushed the edgecore_stop_channel branch from e29bb0b to 2b2f4af Compare November 12, 2019 04:54
@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 12, 2019
@kadisi
Copy link
Member Author

kadisi commented Nov 12, 2019

@kevin-wangzefeng @fisherxu PTAL

@kadisi kadisi force-pushed the edgecore_stop_channel branch 2 times, most recently from 3592901 to b52dbf6 Compare November 12, 2019 08:24
fisherxu
fisherxu reviewed Nov 13, 2019
View reviewed changes
@kadisi
servivebus:uses the golang context instead of the stop channel
ef3067a 
Signed-off-by: zhangjie <iamkadisi@163.com>
@kadisi kadisi force-pushed the edgecore_stop_channel branch from b52dbf6 to ef3067a Compare November 13, 2019 09:24
@fisherxu
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
kevin-wangzefeng
kevin-wangzefeng reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@kubeedge-bot kubeedge-bot merged commit 4fbdd7b into kubeedge:master Nov 13, 2019
@kadisi kadisi deleted the edgecore_stop_channel branch November 13, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@fisherxu fisherxu fisherxu left review comments

@anyushun anyushun Awaiting requested review from anyushun

@edisonxiang edisonxiang Awaiting requested review from edisonxiang

@sids-b sids-b Awaiting requested review from sids-b

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadisi @kevin-wangzefeng @fisherxu @kubeedge-bot