-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kArmor probe utility #19 #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, Looks like a great start 😄
Left some comments inline.
Let's either
- detect Enforcement/LSM for host
or - detect Observability Support in K8s environement
in the same PR.WDYT? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments inline.
Can you please check and fix the Linter Warnings?
And there's an empty file running.config
committed for some reason, can that be reverted?
Thank You :)
issues has been resolved, kindly review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress 🚀
Can you share how's the output screen is looking like?
Left some nits inline.
Also can you take a look at the failing CI?
Thank You 😸
@Essietom , can you rebase the code to latest and squash the commits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Work 🚀
Some comments inline.
Can you handle the linter warning & CI errors, and squash the commits?
Thank You 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Find some comments, feedback and nitpicks inline 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you handle the formatting?
Signed-off-by: essietom <essietom@gmail.com> squash all commits for karmor probe utility rename methods properly Signed-off-by: essietom <essietom@gmail.com> check supported enforcement for host Signed-off-by: essietom <essietom@gmail.com> correct print output Signed-off-by: essietom <essietom@gmail.com> rrefactor code to remove redundancy Signed-off-by: essietom <essietom@gmail.com> format text output Signed-off-by: essietom <essietom@gmail.com> check node observability support Signed-off-by: essietom <essietom@gmail.com> refactor code Signed-off-by: essietom <essietom@gmail.com> refactor code Signed-off-by: essietom <essietom@gmail.com> refactor code Signed-off-by: essietom <essietom@gmail.com> refactor code Signed-off-by: essietom <essietom@gmail.com> remove non probe commits Signed-off-by: essietom <essietom@gmail.com> probe deployment Signed-off-by: essietom <essietom@gmail.com> handle error from bold text Signed-off-by: essietom <essietom@gmail.com> refactor code, check bpf support in lsm, check lib module in kernel header Signed-off-by: essietom <essietom@gmail.com> format code fix indentation Signed-off-by: essietom <essietom@gmail.com> add licence identifier Signed-off-by: essietom <essietom@gmail.com>
Utility to analyse configuration and supported KubeArmor features in the current environment
Previously, karmor doesn't check if a the host machine on which kubearmor will be installed supports audit, this utility will give users headsup as to weather kubearmor will be supported on their machine or not.
This update allows karmor to check if audit/observability is supported on a host machine before installation of kubearmor is done
Fixes: #19 (partially)
Signed-off-by: Esther Adenekan essietom@gmail.com