Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kArmor probe utility #19 #86

Merged
merged 1 commit into from
Aug 12, 2022
Merged

kArmor probe utility #19 #86

merged 1 commit into from
Aug 12, 2022

Conversation

Essietom
Copy link
Contributor

@Essietom Essietom commented Jun 15, 2022

Utility to analyse configuration and supported KubeArmor features in the current environment

Previously, karmor doesn't check if a the host machine on which kubearmor will be installed supports audit, this utility will give users headsup as to weather kubearmor will be supported on their machine or not.

This update allows karmor to check if audit/observability is supported on a host machine before installation of kubearmor is done

Fixes: #19 (partially)

Signed-off-by: Esther Adenekan essietom@gmail.com

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, Looks like a great start 😄

Left some comments inline.
Let's either

  • detect Enforcement/LSM for host
    or
  • detect Observability Support in K8s environement

in the same PR.WDYT? :)

@daemon1024 daemon1024 requested review from Ankurk99 and nyrahul June 15, 2022 17:01
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments inline.

Can you please check and fix the Linter Warnings?
And there's an empty file running.config committed for some reason, can that be reverted?

Thank You :)

@Essietom
Copy link
Contributor Author

issues has been resolved, kindly review

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress 🚀
Can you share how's the output screen is looking like?

Left some nits inline.
Also can you take a look at the failing CI?

Thank You 😸

@Essietom
Copy link
Contributor Author

Screenshot 2022-06-24 at 10 21 45

This is the output

@nyrahul
Copy link
Contributor

nyrahul commented Jun 27, 2022

@Essietom , can you rebase the code to latest and squash the commits?

@daemon1024 daemon1024 marked this pull request as draft June 28, 2022 05:32
@daemon1024 daemon1024 marked this pull request as ready for review July 2, 2022 06:21
@daemon1024 daemon1024 self-requested a review July 2, 2022 06:22
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work 🚀

Some comments inline.

Can you handle the linter warning & CI errors, and squash the commits?

Thank You 😄

@Essietom
Copy link
Contributor Author

Essietom commented Jul 4, 2022

Screenshot 2022-07-04 at 07 08 55

New output

@daemon1024 daemon1024 self-requested a review July 7, 2022 15:24
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Find some comments, feedback and nitpicks inline 😁

@daemon1024 daemon1024 self-requested a review August 12, 2022 11:47
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you handle the formatting?

Signed-off-by: essietom <essietom@gmail.com>

squash all commits for karmor probe utility

rename methods properly

Signed-off-by: essietom <essietom@gmail.com>

check supported enforcement for host

Signed-off-by: essietom <essietom@gmail.com>

correct print output

Signed-off-by: essietom <essietom@gmail.com>

rrefactor code to remove redundancy

Signed-off-by: essietom <essietom@gmail.com>

format text output

Signed-off-by: essietom <essietom@gmail.com>

check node observability support

Signed-off-by: essietom <essietom@gmail.com>

refactor code

Signed-off-by: essietom <essietom@gmail.com>

refactor code

Signed-off-by: essietom <essietom@gmail.com>

refactor code

Signed-off-by: essietom <essietom@gmail.com>

refactor code

Signed-off-by: essietom <essietom@gmail.com>

remove non probe commits

Signed-off-by: essietom <essietom@gmail.com>

probe deployment

Signed-off-by: essietom <essietom@gmail.com>

handle error from bold text

Signed-off-by: essietom <essietom@gmail.com>

refactor code, check bpf support in lsm, check lib module in kernel header

Signed-off-by: essietom <essietom@gmail.com>

format code fix indentation

Signed-off-by: essietom <essietom@gmail.com>

add licence identifier

Signed-off-by: essietom <essietom@gmail.com>
@daemon1024 daemon1024 merged commit 00cb5c3 into kubearmor:main Aug 12, 2022
@daemon1024 daemon1024 mentioned this pull request Aug 12, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kArmor probe utility
3 participants