-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tokio-tungstenite requirement from 0.15.0 to 0.16.0 #732
Conversation
welp, well, it "works". but it doesn't upgrade with |
Do you mean all outdated crates in a single PR? |
No, I mean bump the single dependency in all crates (currently it does single dependency in one crate). Otherwise we end up with multiple versions (which we now block on cargo deny against). |
Actually, that might not be true. I just assumed it was doing per crate. This PR does the only crate it needs to update it, but |
Yeah, the duplicate version is because of transitive dependencies ( |
Maybe we should just exclude examples from the dupe check? |
I think that makes sense for cargo-deny, but I am also happy with keeping it there. It's nice to limit dupes when possible (as in the most recent PR that duplicates tracing-subscriber) to avoid double compiles. It looks like dependabot should be able to upgrade all workspace crates from quick scans on their issues: dependabot/dependabot-core#1207 EDIT: that is what it is doing. |
9f9f640
to
2aea5b6
Compare
This comment has been minimized.
This comment has been minimized.
Updates the requirements on [tokio-tungstenite](https://github.com/snapview/tokio-tungstenite) to permit the latest version. - [Release notes](https://github.com/snapview/tokio-tungstenite/releases) - [Changelog](https://github.com/snapview/tokio-tungstenite/blob/master/CHANGELOG.md) - [Commits](snapview/tokio-tungstenite@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: tokio-tungstenite dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
2aea5b6
to
74cb1ea
Compare
Superseded by #750. |
Updates the requirements on tokio-tungstenite to permit the latest version.
Changelog
Sourced from tokio-tungstenite's changelog.
Commits
84c7488
Update the changelog4298e9e
Bump version7a520c2
Merge pull request #198 from dnaka91/rustls-0.20ec14883
Update dependencies to official releases49d4e0b
Upgrade to rustls 0.20b40114e
Re-port #90 (#194)2bfd4cd
Fix the echo server example to prevent ConnectionClosed error (#189)d566387
Update the changelogcb24743
Fail with TlsFeatureNotEnabled if connecting to wss without the feature (#186)171a452
Merge pull request #184 from dnaka91/rustls-rootsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)