Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio-tungstenite requirement from 0.15.0 to 0.16.0 #732

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 23, 2021

Updates the requirements on tokio-tungstenite to permit the latest version.

Changelog

Sourced from tokio-tungstenite's changelog.

0.16.0 (Unreleased)

  • Add a function to allow to specify the TLS connector when using connect() like logic.
  • Add support for choosing the right root certificates for the TLS.
  • Change the behavior of the connect() so that it fails when using TLS without TLS feature.
  • Do not project with Unpin.
  • Update the dependencies with important implications / improvements.

0.15.0

0.14.0

  • Support for rustls as TLS backend.
    • The tls feature was renamed to native-tls and uses a OS-native TLS implementation.
    • A new native-tls-vendored feature that uses native-tls but forces to build a vendored version (mostly for openssl) instead of linking against the system installation.
    • New rustls-tls feature flag to enable TLS with rustls as backend.
    • stream::Stream was renamed to MaybeTlsStream and wraps a rustls TLS stream as well now.
    • If both native-tls and rustls-tls are enabled native-tls is used by default.
    • A new Connector was introduced that is similar to the previous TlsConnector but now allows to control the used TLS backend explicitly (or disable it) in client_async_tls_with_config.

0.13.0

  • Upgrade from Tokio 0.3 to Tokio 1.0.0.
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies upgrades to dependencies label Nov 23, 2021
@clux
Copy link
Member

clux commented Nov 23, 2021

welp, well, it "works". but it doesn't upgrade with cargo upgrade --all :/

@kazk
Copy link
Member

kazk commented Nov 23, 2021

welp, well, it "works". but it doesn't upgrade with cargo upgrade --all :/

Do you mean all outdated crates in a single PR?

@clux
Copy link
Member

clux commented Nov 23, 2021

No, I mean bump the single dependency in all crates (currently it does single dependency in one crate). Otherwise we end up with multiple versions (which we now block on cargo deny against).

@clux
Copy link
Member

clux commented Nov 23, 2021

Actually, that might not be true. I just assumed it was doing per crate. This PR does the only crate it needs to update it, but cargo deny check seems to be confused about it for lockfile reasons 🤔

@kazk
Copy link
Member

kazk commented Nov 23, 2021

Yeah, the duplicate version is because of transitive dependencies (warp depends on older version).

@nightkr
Copy link
Member

nightkr commented Nov 24, 2021

Maybe we should just exclude examples from the dupe check?

@clux
Copy link
Member

clux commented Nov 24, 2021

I think that makes sense for cargo-deny, but I am also happy with keeping it there. It's nice to limit dupes when possible (as in the most recent PR that duplicates tracing-subscriber) to avoid double compiles.

It looks like dependabot should be able to upgrade all workspace crates from quick scans on their issues: dependabot/dependabot-core#1207 EDIT: that is what it is doing.

@dependabot dependabot bot force-pushed the dependabot/cargo/tokio-tungstenite-0.16.0 branch from 9f9f640 to 2aea5b6 Compare December 6, 2021 05:49
@codecov-commenter

This comment has been minimized.

Updates the requirements on [tokio-tungstenite](https://github.com/snapview/tokio-tungstenite) to permit the latest version.
- [Release notes](https://github.com/snapview/tokio-tungstenite/releases)
- [Changelog](https://github.com/snapview/tokio-tungstenite/blob/master/CHANGELOG.md)
- [Commits](snapview/tokio-tungstenite@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: tokio-tungstenite
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/tokio-tungstenite-0.16.0 branch from 2aea5b6 to 74cb1ea Compare December 6, 2021 08:12
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 7, 2021

Superseded by #750.

@dependabot dependabot bot closed this Dec 7, 2021
@dependabot dependabot bot deleted the dependabot/cargo/tokio-tungstenite-0.16.0 branch December 7, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants