[vmm]: add vmm-sandboxer as a systemd service #44

flyflypeng · 2023-07-13T07:53:47Z

Fix: #4

reason: add vmm-sandboxer as a systemd service

abel-von · 2023-07-13T13:11:15Z

vmm/service/kuasar-vmm

+OPTIONS='--listen /run/vmm-sandboxer.sock --dir /run/kuasar-vmm'
+
+# set vmm-sandboxer log level
+RUST_LOG=info


is this log level duplicated with the loglevel config added in the #36?

I want to provide two ways to configure the vmm-sandboxer process's log level. In this place, keep the original way to set the log level by RUST_LOG environment which is set by default.
Another way in the #36 provides to configure log level in the config_<hypervisor>.toml file which is more flexible for user to change the log level.

#36 supports log_level set in the config_<hypervisor>.toml file overrides the default log level set in the /etc/sysconfig/kuasar-vmm environment file.

it seems the env of RUST_LOG is enough to set the log level and it is simple. keeping these to ways to set the log level makes things complicated, I am wondering if we have to revert the #36 ?

It does seem a bit repetitive, and I think it's better to keep the support for configuring it in the config file rather than in an systemd service env file.
So, we don't need to revert the #36, just remove the RUST_LOG env option in the /etc/sysconfig/kuasar-vmm env file.

abel-von · 2023-07-13T13:13:21Z

vmm/sandbox/src/main.rs

+
+    // notify the systemd about state changes
+    #[cfg(feature = "systemd")]
+    sd_notify::notify(false, &[sd_notify::NotifyState::Ready])?;


is it necssary to do this intrusive modification to support systemd?

Yes, if the type field value is notify in the systemd service file, it is necessary for the daemon process to notify the systemd that the service is ready.

So, can we just set the type of service to simple, this services seems not that complicated, only the sandboxer process is included, why do we need to set the service type to notify?

Nice suggestion, maybe the simple type is the simplest and enough for the kuasar-vmm service.
I used to reference the service file from the containerd.service which started as a notify type systemd service.

moby/moby@d3e5179

The key point is whether or not someone is going to get the status of the kuasar-vmm service, if not, I think simple type is enough.

Burning1020

Nice work. Please update README.md at the same time.

Burning1020 · 2023-07-14T06:27:58Z

docs/vmm/README.md

+
+## Install and run kuasar-vmm systemd service
+
+1. Run `make install-vmm` to install vmm-sandboxer related executable file, configuraiton files, and `kuasar-vmm` systemd service file into the destination directory. 


Typo, configuration

Burning1020 · 2023-07-14T06:43:55Z

vmm/sandbox/src/main.rs

@@ -158,6 +158,10 @@ async fn main() -> anyhow::Result<()> {
    }
    builder.init();

+    // notify the systemd about state changes
+    #[cfg(feature = "systemd")]
+    sd_notify::notify(false, &[sd_notify::NotifyState::Ready])?;


Should we ignore the error returned by notify and keep on running? Probably just record this error in logs.
So that we don't need the "systemd" feature.

I've thought about this, but if the sd_notify execution fails to continue down the line, then systemctl start kuasar-vmm systemd service will be blocked forever and kuasar-vmm systemd service will abnormal.

I found both dockerd and containerd all ignored this error.

I found both dockerd and containerd all ignored this error.

If we just ignore the error with notify type systemd service, which will cause systemctl start command blocked until exceeding the timeout.

abel-von · 2023-07-17T09:32:44Z

vmm/sandbox/Cargo.toml

@@ -45,4 +45,4 @@ rtnetlink = "0.12"
 netlink-packet-route = "0.15"
 netlink-packet-core = "0.5.0"
 ttrpc = { version = "0.7", features = ["async"] }
-protobuf = "3.2"
+protobuf = "3.2"


is it an empty line that is not necessary？

protobuf this line is already exist in the Cargo.toml, this change maybe compared the pre commit in the current PR.

abel-von · 2023-07-17T09:33:32Z

Makefile


 .PHONY: vmm wasm quark clean all install-vmm install-wasm install-quark install 

 all: vmm quark wasm

 bin/vmm-sandboxer:
+ifeq ($(RUN_AS_SYSTEMD_SERVICE), true)
+	@cd vmm/sandbox && cargo build --release --features=${HYPERVISOR},systemd


we don't have a feature of systemd anymore if the service type is simple.

Fix: kuasar-io#4 reason: 1. add vmm-sandboxer as a systemd service 2. minimising installation file permissions Signed-off-by: flyflypeng <flyflyflypeng@gmail.com>

Burning1020

LGTM

vmm/service/kuasar-vmm

flyflypeng force-pushed the add-systemd-service branch from 50b6b8f to ea21513 Compare July 13, 2023 09:23

abel-von reviewed Jul 13, 2023

View reviewed changes

flyflypeng force-pushed the add-systemd-service branch from fe5a68c to de2625a Compare July 14, 2023 02:03

Burning1020 reviewed Jul 14, 2023

View reviewed changes

flyflypeng force-pushed the add-systemd-service branch 2 times, most recently from 5825c23 to 63c12ef Compare July 14, 2023 09:12

abel-von reviewed Jul 17, 2023

View reviewed changes

flyflypeng force-pushed the add-systemd-service branch 2 times, most recently from 5cc1c0d to d1931cf Compare July 18, 2023 02:47

[vmm]: add vmm-sandboxer as a systemd service

9f7270a

Fix: kuasar-io#4 reason: 1. add vmm-sandboxer as a systemd service 2. minimising installation file permissions Signed-off-by: flyflypeng <flyflyflypeng@gmail.com>

flyflypeng force-pushed the add-systemd-service branch from d1931cf to 9f7270a Compare July 18, 2023 11:54

Burning1020 approved these changes Jul 18, 2023

View reviewed changes

Burning1020 merged commit a08a8dd into kuasar-io:main Jul 18, 2023

abel-von reviewed Jul 18, 2023

View reviewed changes

vmm/service/kuasar-vmm Outdated Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vmm]: add vmm-sandboxer as a systemd service #44

[vmm]: add vmm-sandboxer as a systemd service #44

flyflypeng commented Jul 13, 2023

abel-von Jul 13, 2023

flyflypeng Jul 14, 2023

abel-von Jul 14, 2023

flyflypeng Jul 14, 2023

abel-von Jul 13, 2023

flyflypeng Jul 14, 2023

abel-von Jul 14, 2023

flyflypeng Jul 14, 2023

Burning1020 Jul 14, 2023

flyflypeng Jul 14, 2023

Burning1020 left a comment

Burning1020 Jul 14, 2023

flyflypeng Jul 14, 2023

Burning1020 Jul 14, 2023

flyflypeng Jul 14, 2023

Burning1020 Jul 14, 2023

flyflypeng Jul 14, 2023

abel-von Jul 17, 2023 •

edited

Loading

flyflypeng Jul 17, 2023

abel-von Jul 17, 2023 •

edited

Loading

flyflypeng Jul 17, 2023

Burning1020 left a comment


		## Install and run kuasar-vmm systemd service

		1. Run `make install-vmm` to install vmm-sandboxer related executable file, configuraiton files, and `kuasar-vmm` systemd service file into the destination directory.

[vmm]: add vmm-sandboxer as a systemd service #44

[vmm]: add vmm-sandboxer as a systemd service #44

Conversation

flyflypeng commented Jul 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Burning1020 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abel-von Jul 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abel-von Jul 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Burning1020 left a comment

Choose a reason for hiding this comment

abel-von Jul 17, 2023 •

edited

Loading

abel-von Jul 17, 2023 •

edited

Loading