vmm: Unshare IPC and UTS namespaces for container process #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e385ece to
58a1614
Compare
abel-von
reviewed
Jan 12, 2024
| } | ||
|
|
||
| // Update container hostname to sandbox hostname | ||
| spec.hostname = hostname; |
There was a problem hiding this comment.
will these two values be different？
There was a problem hiding this comment.
Containerd would not set hostname for container, it only set it to pod.
| } | ||
|
|
||
| thread::spawn(move || { | ||
| unshare(clone_type).expect("failed to do unshare"); |
There was a problem hiding this comment.
will this affect the whole process?
| @@ -71,6 +77,20 @@ where | |||
| } | |||
| // Update sandbox files mounts for container | |||
| container_mounts(&shared_path, spec); | |||
|
|
|||
| // Update ipc and uts namespace for container | |||
| if let Some(linux) = spec.linux.as_mut() { | |||
There was a problem hiding this comment.
there is a namespace handler, which is doing similar things
4696b10 to
dafab32
Compare
Container process needs a POD level IPC and UTS namespace unshared with kuasar-task by default as pause container has been removed. In this commit, kuasar-task will unshare a new ns and bind mount it to `/run/sandbox-ns`, in which the container could join. The hostname in the sandbox pod config will be set into uts ns by runC when creating container. Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
dafab32 to
80d40e1
Compare
abel-von
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container process needs a POD level IPC and UTS namespace unshared with kuasar-task by default as pause container has been removed.
In this commit, kuasar-task will unshare a new ns and bind mount it to
/run/sandbox-ns, in which the container could join. The hostname in the sandbox pod config will be set into uts ns by runC when creating container.TODO: Pod level PID namespace implementation.