Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prompt in the instructions to copy valid command #573

Merged
merged 2 commits into from
Aug 21, 2022

Conversation

rexposadas
Copy link
Contributor

The copy button copies the command prompt. We should remove the command prompt so that what is copied is valid.

I.e. I should be able to click on the "copy" icon and paste directly to the terminal. What is entered in that terminal should be a valid command.

Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you remove it from other examples?

@rexposadas
Copy link
Contributor Author

Sure thing. I removed the prompt where it made sense.

In other spots I left them in since those spots are meant as examples and not necessary for cutting and pasting directly to the command line.

@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #573 (fde0006) into master (4757a73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   80.17%   80.17%           
=======================================
  Files          57       57           
  Lines        3848     3848           
=======================================
  Hits         3085     3085           
  Misses        536      536           
  Partials      227      227           

Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ktr0731 ktr0731 merged commit e6da0e0 into ktr0731:master Aug 21, 2022
@rexposadas rexposadas deleted the fix-homebrew-install branch August 24, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants