add prefix for enum type #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktr0731
reviewed
Jan 7, 2022
d20ebb1 to
4620275
Compare
|
I misunderstood. I update the diff, is this the effect you want?
|
ktr0731
reviewed
Jan 10, 2022
4620275 to
883102f
Compare
ktr0731
reviewed
Jan 11, 2022
| choices := make([]string, 0, len(e.GetValues())) | ||
| for _, v := range e.GetValues() { | ||
| choices = append(choices, v.GetName()) | ||
| } | ||
|
|
||
| choice, err := r.selectChoices(e.GetFullyQualifiedName(), choices) | ||
| choice, err := r.selectChoices(prefix, choices) |
There was a problem hiding this comment.
Since the prompt has an unnecessary character :, it's better to trim it like ? choice (TYPE_ENUM) =>.
This can be pass a template through Templates.Label of promptui.Select (the implementation of the prompt).
FYI: the default template label is maybe here.
There was a problem hiding this comment.
I updated the diff. Wait a minute, maybe it's better to pass the template.
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
- Coverage 80.23% 80.15% -0.09%
==========================================
Files 57 57
Lines 3840 3844 +4
==========================================
Hits 3081 3081
- Misses 532 536 +4
Partials 227 227 |
883102f to
0fc2236
Compare
ktr0731
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multiple fields of the same enum type in a proto message, it's confusing not to prompt which field to enter...
After the change:
