Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go install instead of go get #475

Merged
merged 1 commit into from
Nov 12, 2021
Merged

go install instead of go get #475

merged 1 commit into from
Nov 12, 2021

Conversation

DQNEO
Copy link
Contributor

@DQNEO DQNEO commented Nov 11, 2021

The official doc says:

https://golang.org/doc/go-get-install-deprecation

Starting in Go 1.17, installing executables with go get is deprecated.

In order to use "go install", the requirement of the minimum version should also be updated. (v1.13 -> v1.16)

I think this change will help users who prefer using go install to brew tap.

Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for your contribution!

@ktr0731 ktr0731 enabled auto-merge (squash) November 11, 2021 05:17
@ktr0731 ktr0731 disabled auto-merge November 12, 2021 14:39
@ktr0731 ktr0731 merged commit d96bd15 into ktr0731:master Nov 12, 2021
@DQNEO DQNEO deleted the patch-1 branch November 16, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants