Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/jhump/protoreflect from 1.8.2 to 1.9.0 #451

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 15, 2021

Bumps github.com/jhump/protoreflect from 1.8.2 to 1.9.0.

Release notes

Sourced from github.com/jhump/protoreflect's releases.

v1.9.0

This release contains numerous improvements to the protoparse package, to more closely match protoc in terms of proto source files that are acceptable. It also contains some fixes in other packages.

"github.com/jhump/protoreflect/desc/builder"

Changes/fixes:

  • When adding a message to another (to make a nested/enclosed type), the target enclosing message could be incorrectly detached from its parent element. This was the result of a typo in the implementation code and has been fixed.

"github.com/jhump/protoreflect/desc/protoparse"

Additions:

  • The protoparse package now issues warnings when it detects that a source file has unused imports. This mirrors the warnings that protoc issues in the same cases. This feature requires the use of a WarningReporter with a parse operation. The concrete type of value provided to the warning reporter will be a protoparse.ErrorUnusedImport.

Changes/fixes:

  • The protoc compiler was more strict than protoparse when it comes to resolving relative (vs. full qualified) names. This led to conditions where protoparse would accept a proto source file that protoc would reject. The issue is when the first component of an identifier could match multiple lexical scopes. In such a case protoc only matches the most enclosing scope. But protoparse would fallback to other enclosing scopes if the most enclosing scope could not be used to resolve a symbol. (Hard to describe succinctly, so see the example in this bug report.) This issue is now fixed and protoparse resolves names in the same manner as protoc.
  • The protoc compiler uses "C++ enum scoping rules" for protobuf enums. This means that enum values are declared in the namespace of the enclosing enum (as siblings of the enum itself). But protoparse incorrectly treated the enum as the parent scope/namespace. This led to source files that protoparse would accept but that protoc would reject. This issue is now fixed.
  • The use of custom options in oneof statements could incorrectly result in error messages about failing to resolve the custom option name, even if the source file and the option reference were valid. This has been fixed.

"github.com/jhump/protoreflect/dynamic/msgregistry"

Additions:

  • A new error type, ErrUnexpectedType, was introduced. When a call to FindMessageTypeByUrl or FindEnumTypeByUrl fails because of a type mismatch (expecting a message, got an enum, or vice versa), this can now be determined programmatically by type-asserting the error to the new error type. This provides a proper/robust way to detect this kind of error (previously, callers would have to examine the error text, which is quite brittle).
Commits
  • d3608fa protoparse: oops, we weren't ever linking options for oneofs (#408)
  • 6cc1efa protoparse: report warnings when a file has unused imports (#403)
  • ac729f7 protoparse: c++ scoping rules for enum values (#401)
  • e5cc6ba protoparse: take 3... still getting scoping rules right (#399)
  • c34b9b1 pin ci badge to master branch
  • bc94b04 switch from travis to circleci (#398)
  • a6abd35 protoparse: take 2 on fixing symbol resolution to properly match protoc's C++...
  • 05026f3 protoparse: fix symbol resolution to correctly mimic protoc behavior, which i...
  • 2837af4 desc/builder: fix typo that resulted in wrong message being removed from its ...
  • 8255811 dynamic/msgregistry: Add typed errors for lookups (#386)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the update label Jul 15, 2021
@dependabot dependabot bot requested a review from ktr0731 July 15, 2021 15:54
@ktr-ci-bot ktr-ci-bot enabled auto-merge (squash) July 15, 2021 15:55
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #451 (e014527) into master (d674636) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          57       57           
  Lines        3839     3839           
=======================================
  Hits         3080     3080           
  Misses        532      532           
  Partials      227      227           

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/jhump/protoreflect-1.9.0 branch from 0f82945 to 05127e7 Compare July 15, 2021 16:17
@ktr0731 ktr0731 disabled auto-merge July 24, 2021 15:04
@ktr0731 ktr0731 enabled auto-merge (squash) July 24, 2021 15:04
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/jhump/protoreflect-1.9.0 branch from 05127e7 to 9d900e7 Compare August 1, 2021 04:27
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/jhump/protoreflect-1.9.0 branch from 9d900e7 to 4e8a41a Compare September 1, 2021 04:26
Bumps [github.com/jhump/protoreflect](https://github.com/jhump/protoreflect) from 1.8.2 to 1.9.0.
- [Release notes](https://github.com/jhump/protoreflect/releases)
- [Commits](jhump/protoreflect@v1.8.2...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/jhump/protoreflect
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/jhump/protoreflect-1.9.0 branch from 4e8a41a to e014527 Compare September 1, 2021 04:42
@ktr0731 ktr0731 merged commit a870046 into master Sep 2, 2021
@ktr0731 ktr0731 deleted the dependabot/go_modules/github.com/jhump/protoreflect-1.9.0 branch September 2, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants