Enhancement: in REPL mode allow user to specify path to file for bytes field #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 82.57% 82.47% -0.10%
==========================================
Files 57 57
Lines 3139 3156 +17
==========================================
+ Hits 2592 2603 +11
- Misses 313 316 +3
- Partials 234 237 +3 |
|
the build is failed because of the additional \r byte in windows files. |
e9e25bb to
d6b5032
Compare
BenSlabbert
commented
May 12, 2020
| @@ -1,16 +1,86 @@ | |||
| package proto_test | |||
| package proto | |||
There was a problem hiding this comment.
I dropped the _test because I needed access to the internal function I wanted to test.
ktr0731
reviewed
May 17, 2020
fill/proto/interactive_filler.go
Outdated
| @@ -213,7 +217,7 @@ func (f *InteractiveFiller) inputField(dmsg *dynamic.Message, field *desc.FieldD | |||
| f.state.color.Next() | |||
| default: // Normal fields. | |||
| f.prompt.SetPrefix(f.makePrefix(field)) | |||
| v, err := f.inputPrimitiveField(field) | |||
| v, err := f.inputPrimitiveField(descriptor.FieldDescriptorProto_Type(descriptor.FieldDescriptorProto_Type_value[field.GetType().String()])) | |||
There was a problem hiding this comment.
Suggested change
| v, err := f.inputPrimitiveField(descriptor.FieldDescriptorProto_Type(descriptor.FieldDescriptorProto_Type_value[field.GetType().String()])) | |
| v, err := f.inputPrimitiveField(field.GetType()) |
fill/proto/interactive_filler.go
Outdated
Comment on lines
472
to
475
| absPath, err := filepath.Abs(path) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
These lines are unnecessary because ioutil.ReadFile also accepts relative paths.
There was a problem hiding this comment.
didn't know that :)
| @@ -301,7 +305,7 @@ func (f *InteractiveFiller) inputRepeatedField(dmsg *dynamic.Message, field *des | |||
|
|
|||
| // inputPrimitiveField reads an input and converts it to a Go type. | |||
| // If CTRL+d is entered, inputPrimitiveField returns io.EOF. | |||
| func (f *InteractiveFiller) inputPrimitiveField(field *desc.FieldDescriptor) (interface{}, error) { | |||
| func (f *InteractiveFiller) inputPrimitiveField(fieldType descriptor.FieldDescriptorProto_Type) (interface{}, error) { | |||
Comment on lines
11
to
13
| type testPrompt struct { | ||
| input string | ||
| } |
There was a problem hiding this comment.
Can you embed prompt.Prompt and remove methods other than Input?
Suggested change
| type testPrompt struct { | |
| input string | |
| } | |
| type testPrompt struct { | |
| prompt.Prompt | |
| input string | |
| } |
There was a problem hiding this comment.
great suggestion thank you!
ktr0731
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see Issue: #279