tweak output layout (#278)

ktr0731 · Apr 29, 2020 · 2134fc2 · 2134fc2
1 parent 3dbcdbf
commit 2134fc2
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 11 deletions.
diff --git a/...testdata/fixtures/teste2e_cli-call_failure_unary_rpc_with_--enrich_and_json_format.golden b/...testdata/fixtures/teste2e_cli-call_failure_unary_rpc_with_--enrich_and_json_format.golden
@@ -36,9 +36,6 @@
       "header_val2"
     ]
   },
-  "messages": [
-    {}
-  ],
   "trailer": {
     "trailer_key1": [
       "trailer_val1"

diff --git a/e2e/testdata/fixtures/teste2e_cli-call_failure_unary_rpc_with_--enrich_flag.golden b/e2e/testdata/fixtures/teste2e_cli-call_failure_unary_rpc_with_--enrich_flag.golden
@@ -2,8 +2,6 @@ content-type: application/grpc
 header_key1: header_val1
 header_key2: header_val2
 
-{}
-
 trailer_key1: trailer_val1
 trailer_key2: trailer_val2
 
@@ -13,3 +11,4 @@ message: "internal error"
 details: 
   {"@type": "type.googleapis.com/google.rpc.BadRequest", "fieldViolations": [{"description": "description", "field": "field"}]}
   {"@type": "type.googleapis.com/google.rpc.PreconditionFailure", "violations": [{"description": "description", "subject": "subject", "type": "type"}]}
+
diff --git a/...s/teste2e_cli-call_failure_unary_rpc_with_--enrich_flag_against_to_grpc-web_server.golden b/...s/teste2e_cli-call_failure_unary_rpc_with_--enrich_flag_against_to_grpc-web_server.golden
@@ -3,8 +3,6 @@ header_key1: header_val1
 header_key2: header_val2
 vary: Origin
 
-{}
-
 trailer_key1: trailer_val1
 trailer_key2: trailer_val2
 
@@ -14,3 +12,4 @@ message: "internal error"
 details: 
   {"@type": "type.googleapis.com/google.rpc.BadRequest", "fieldViolations": [{"description": "description", "field": "field"}]}
   {"@type": "type.googleapis.com/google.rpc.PreconditionFailure", "violations": [{"description": "description", "subject": "subject", "type": "type"}]}
+
diff --git a/...ll_unaryheadertrailerfailure_by_selecting_package_and_service_with_enriched_output.golden b/...ll_unaryheadertrailerfailure_by_selecting_package_and_service_with_enriched_output.golden
@@ -4,8 +4,6 @@ content-type: application/grpc
 header_key1: header_val1
 header_key2: header_val2
 
-{}
-
 trailer_key1: trailer_val1
 trailer_key2: trailer_val2
 
@@ -16,3 +14,4 @@ details:
   {"@type": "type.googleapis.com/google.rpc.BadRequest", "fieldViolations": [{"description": "description", "field": "field"}]}
   {"@type": "type.googleapis.com/google.rpc.PreconditionFailure", "violations": [{"description": "description", "subject": "subject", "type": "type"}]}
 
+
diff --git a/format/curl/curl.go b/format/curl/curl.go
@@ -17,6 +17,7 @@ import (
 	"github.com/ktr0731/evans/present/json"
 	"github.com/pkg/errors"
 	_ "google.golang.org/genproto/googleapis/rpc/errdetails" // For calling RegisterType.
+	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/metadata"
 	"google.golang.org/grpc/status"
 )
@@ -118,6 +119,9 @@ func (p *responseFormatter) FormatStatus(status *status.Status) error {
 		}
 		fmt.Fprintf(p.w, "details: \n%s\n", strings.Join(details, "\n"))
 	}
+	if status.Code() != codes.OK {
+		fmt.Fprintf(p.w, "\n")
+	}
 	return nil
 }
 

diff --git a/format/format.go b/format/format.go
@@ -2,7 +2,6 @@
 package format
 
 import (
-	"github.com/golang/protobuf/ptypes/empty"
 	"google.golang.org/grpc/metadata"
 	"google.golang.org/grpc/status"
 )
@@ -33,7 +32,7 @@ func (f *ResponseFormatter) FormatHeader(header metadata.MD) {
 
 func (f *ResponseFormatter) FormatMessage(v interface{}) error {
 	if v == nil {
-		v = &empty.Empty{}
+		return nil
 	}
 	return f.impl.FormatMessage(v)
 }