A file which matches the pattern in multiple ways is returned multiple times

[robvanuden]

Suppose I have the following file:
C:\files\a\a\a\b.txt
When I use the following code:
string[] matchingFiles = Glob.Files(@"C:\files", "**/a/**/b.txt").ToArray();
matchingFiles result is:

[0] = a\a\a\b.txt
[1] = a\a\a\b.txt
[2] = a\a\a\b.txt

When I add another a\ subfolder, it gets another item added etc.

Is this by design? I would rather get distinct values.

[kthompson]

No this is definitely not intentional. I will see if i can determine the cause.

[robvanuden]

@kthompson I'm new to this code, but when I append .Distinct() to this line it's working correctly.

I think when you want to fix this thoroughly, the code needs a serious refactoring.

Not sure what you want, so haven't created a PR (yet)...

[kthompson]

That would be one way to solve it but I am wondering if there is a way to prevent the traversal.

How would you suggest refactoring that would enable PathTraverser to prevent traversals that result in duplicate results?

[ffMathy]

How about just using a HashSet<string> to store the paths? That way, duplicates won't be stored, and it's O(1) insertion time complexity (almost no cost).

[kthompson]

Fixed in version 1.1.7