Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @eLog contacts and project description on Hungarian language to README. #46

Closed
kslazarev opened this issue Feb 7, 2013 · 2 comments
Assignees
Milestone

Comments

@kslazarev
Copy link
Owner

It's really nice that all code, examples exist and located in right place for Hungarian language. Great contribution to project. I have already added @eLod to repo.

Thank you/Köszönöm, @eLod

Any questions you could ask here or by email.
This issue is blocking release right now, so please, close this task as fast, as possible.

@ghost ghost assigned eLod Feb 7, 2013
@eLod
Copy link
Collaborator

eLod commented Feb 7, 2013

i'll look into this. a couple questions:

1, i noticed in the readme section not everything is translated to every language (like the code examples are, but the headlines, other strings are only translated to english + russian + french i believe), how should i proceed?
2, also an overlook on my part: i added 'hungarian' to the language list, should i add 'magyar' (hungarian in hungarian) instead?
3, should i just commit on the development branch, or should i create a topic branch?
+1, also i'm not sure if i need to refactor some things (i saw there were a couple new commits, haven't got the time to look into them yet, but there are some issues, like #38)

@kslazarev
Copy link
Owner Author

  1. "but the headlines, other strings are only translated to english + russian + french i believe"

    Yes, as only 4 languages have native language contributors, other haven't any contributor or haven't native contributor. Also It looks like a mess when there are more than 3 languages in headings. I like that there are instructions for every language, but sometimes want to remove unnecessary information, maybe several READMEs with links could be nice approach. We could discuss about this in issue Ideas to add new language information to README in more readable way. #48.

  2. Yes, 'magyar' preferred.

  3. If there is only one commit you could push in development instead, in other cases create new branch with feature name. (I sometimes use git-flow for this task) In both cases don't forget to add a link to appropriate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants