You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's really nice that all code, examples exist and located in right place for Hungarian language. Great contribution to project. I have already added @eLod to repo.
1, i noticed in the readme section not everything is translated to every language (like the code examples are, but the headlines, other strings are only translated to english + russian + french i believe), how should i proceed?
2, also an overlook on my part: i added 'hungarian' to the language list, should i add 'magyar' (hungarian in hungarian) instead?
3, should i just commit on the development branch, or should i create a topic branch?
+1, also i'm not sure if i need to refactor some things (i saw there were a couple new commits, haven't got the time to look into them yet, but there are some issues, like #38)
"but the headlines, other strings are only translated to english + russian + french i believe"
Yes, as only 4 languages have native language contributors, other haven't any contributor or haven't native contributor. Also It looks like a mess when there are more than 3 languages in headings. I like that there are instructions for every language, but sometimes want to remove unnecessary information, maybe several READMEs with links could be nice approach. We could discuss about this in issue Ideas to add new language information to README in more readable way. #48.
Yes, 'magyar' preferred.
If there is only one commit you could push in development instead, in other cases create new branch with feature name. (I sometimes use git-flow for this task) In both cases don't forget to add a link to appropriate issue.
It's really nice that all code, examples exist and located in right place for Hungarian language. Great contribution to project. I have already added @eLod to repo.
Thank you/Köszönöm, @eLod
Any questions you could ask here or by email.
This issue is blocking release right now, so please, close this task as fast, as possible.
The text was updated successfully, but these errors were encountered: