chore: Split request and response handling parts of the code #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation The current code doesn't have a very clear structure, in particular the request handling logic (JSON->PB) is intermingled with the response handling logic (PB->JSON). Modifications - Split out request handing into separate request.go file and corresponding tests into request_test.go - Minor simplifications to the CustomJSONPb.Marshal and parameterMapToJson functions I'm not renaming marshaler.go to response.go in the same PR because git would probably interpret it as a different file (due to the large number of lines removed at the same time). Result Clearer code Signed-off-by: Nick Hill <nickhill@us.ibm.com>
Signed-off-by: Nick Hill <nickhill@us.ibm.com>
|
I have the two listed changes arranged in separate commits for ease of reviewing, will squash before we merge. |
Signed-off-by: Nick Hill <nickhill@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current code doesn't have a very clear structure, in particular the request handling logic (JSON->PB) is intermingled with the response handling logic (PB->JSON).
Modifications
CustomJSONPb.MarshalandparameterMapToJsonfunctionsrequest.gofile and corresponding tests intorequest_test.go(no code changes apart from moving/reordering)I'm not renaming
marshaler.gotoresponse.goin the same PR because git would probably interpret it as a different file (due to the large number of lines removed at the same time).Result
Clearer code