updated base images for multiple arch support #45
Conversation
Signed-off-by: Pranav Pandit <pranav.pandit1@ibm.com>
1dd5515 to
9de41c6
Compare
|
/assign @yuzisun |
| @@ -9,7 +9,7 @@ RUN git clone https://github.com/kubeflow/kubeflow.git && \ | |||
| git checkout d1da825 | |||
|
|
|||
| # --- Build the backend kubeflow-wheel --- | |||
| FROM python:3.7-slim-buster AS backend-kubeflow-wheel | |||
| FROM python:3.7-slim AS backend-kubeflow-wheel | |||
There was a problem hiding this comment.
Cross posting the same question with kubeflow/kubeflow#6650 (comment)
Why do we remove buster?
There was a problem hiding this comment.
See kubeflow/kubeflow#6650 (comment):
It's "more multi-arch" than the alternative (see screenshot below) & based on our tests, it works equally good.
|
@kimwnasptd - I think we're good to proceed here, right? |
|
@yuzisun, can you lgtm? I think there's nothing special left here, given above comments and that kserve/kserve#2549 and kserve/kserve#2550 also already went through... |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, pranavpandit1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These changes are targeted for multiple architectures compatible base images