fix: Fix possible exception-related ByteBuf leak #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation Some ByteBuf leak errors were reported in a production deployment of model-mesh as described in kserve#97. Modifications In ModelMeshApi, ensure that the response is released if a runtime exception is thrown prior to it being sent successfully. Result Hopefully leak closed Signed-off-by: Nick Hill <nickhill@us.ibm.com>
ckadner
reviewed
Jun 13, 2023
Signed-off-by: Nick Hill <nickhill@us.ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhill, tteofili The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ckadner
pushed a commit
that referenced
this pull request
Jul 24, 2023
#### Motivation Some ByteBuf leak errors were reported in a production deployment of model-mesh as described in #97. #### Modifications In `ModelMeshApi`, ensure that the response is released if a runtime exception is thrown prior to it being sent successfully. #### Result Hopefully leak closed Signed-off-by: Nick Hill <nickhill@us.ibm.com>
ckadner
pushed a commit
that referenced
this pull request
Jul 24, 2023
#### Motivation Some ByteBuf leak errors were reported in a production deployment of model-mesh as described in #97. #### Modifications In `ModelMeshApi`, ensure that the response is released if a runtime exception is thrown prior to it being sent successfully. #### Result Hopefully leak closed Signed-off-by: Nick Hill <nickhill@us.ibm.com>
ckadner
pushed a commit
that referenced
this pull request
Jul 24, 2023
#### Motivation Some ByteBuf leak errors were reported in a production deployment of model-mesh as described in #97. #### Modifications In `ModelMeshApi`, ensure that the response is released if a runtime exception is thrown prior to it being sent successfully. #### Result Hopefully leak closed Signed-off-by: Nick Hill <nickhill@us.ibm.com> (cherry picked from commit c4fc041)
ckadner
pushed a commit
that referenced
this pull request
Jul 24, 2023
#### Motivation Some ByteBuf leak errors were reported in a production deployment of model-mesh as described in #97. #### Modifications In `ModelMeshApi`, ensure that the response is released if a runtime exception is thrown prior to it being sent successfully. #### Result Hopefully leak closed Signed-off-by: Nick Hill <nickhill@us.ibm.com> (cherry picked from commit c4fc041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some ByteBuf leak errors were reported in a production deployment of model-mesh as described in #97.
Modifications
In
ModelMeshApi, ensure that the response is released if a runtime exception is thrown prior to it being sent successfully.Result
Hopefully leak closed