Let RemotePayloadProcessor send also gRPC call Metadata #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream Sync November 8th 2022
Signed-off-by: Tommaso Teofili <tteofili@redhat.com>
Signed-off-by: Tommaso Teofili <tteofili@redhat.com>
Signed-off-by: Tommaso Teofili <tteofili@redhat.com>
7 tasks
njhill
reviewed
May 25, 2023
src/main/java/com/ibm/watson/modelmesh/payload/RemotePayloadProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/watson/modelmesh/payload/RemotePayloadProcessor.java
Outdated
Show resolved
Hide resolved
…ocessor.java Co-authored-by: Nick Hill <nickhill@us.ibm.com> Signed-off-by: Tommaso Teofili <tommaso.teofili@gmail.com>
Signed-off-by: Tommaso Teofili <tteofili@redhat.com>
njhill
approved these changes
May 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill, tteofili The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
RemotePayloadProcessorcurrently doesn't send gRPC callMetadataas part of itsPayloadContent(to a remote endpoint).Such information might be important for many reasons, including debugging purposes.
Modifications
RemotePayloadProcessor'sPayloadContentnow also features aMapthat contains suchMetadatainformation (when available).Result
RemotePayloadProcessorsends alsoMetadatainformation (to a remote endpoint).