fix: Fix direct memory allocation config #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation A bug was introduced in recent PR #61 resulting in the netty direct memory pool size not being set correctly. Modification Add missing $ to variable in bash if condition in start.sh Result Correct netty direct memory allocation size, avoid OOM crashing. Signed-off-by: Nick Hill <nickhill@us.ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chinhuang007, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KillianGolds
pushed a commit
to KillianGolds/modelmesh
that referenced
this pull request
Aug 7, 2024
RHOAIENG-4963: ModelMesh should support TLS in payload processors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A bug was introduced in recent PR #61 resulting in the netty direct memory pool size not being set correctly.
Modification
Add missing
$to variable in bash if condition in start.shResult
Correct netty direct memory allocation size, avoid OOM crashing.