Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ckadner as a reviewer #48

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jul 28, 2022

No description provided.

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@kserve-oss-bot
Copy link
Collaborator

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kserve org. You can then trigger verification by writing /verify-owners in a comment.

  • ckadner
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@ckadner ckadner changed the title Adding myself as a reviewer Adding ckadner as a reviewer Jul 28, 2022
Copy link
Member

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, ckadner, njhill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [animeshsingh,njhill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chinhuang007 chinhuang007 merged commit 69c002d into kserve:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants