chore: Update zookeeper to 3.8.4

[israel-hdez]

This is to move away from CVE-2024-23944: information disclosure.

[rafvasq]

Seems like the tests never finish/fail. At first glance there's a message SLF4J: Class path contains multiple SLF4J bindings. and I haven't been able to connect that to the Zookeeper update yet, but it seems like upgrading <slf4j-version>1.7.36</slf4j-version> to latest (v2.0.12) works. I can continue to look into it, not familiar with these frameworks.

[israel-hdez]

seems like upgrading <slf4j-version>1.7.36</slf4j-version> to latest (v2.0.12) works

I did this and now the tests are finishing, but an error is issued.
I'll also try to look at it closer, but I can't promise progress, given I'm not familiar with the codebase.

[rafvasq]

seems like upgrading <slf4j-version>1.7.36</slf4j-version> to latest (v2.0.12) works

I did this and now the tests are finishing, but an error is issued. I'll also try to look at it closer, but I can't promise progress, given I'm not familiar with the codebase.

Thanks for trying that. I looked into it more and noticed that Zookeeper migrated to logback in 3.8. For now at least, we can exclude it here (and revert slf4j-version):

<dependency>
  <!-- override litelinks' versions with newer to avoid CVE -->
  <groupId>org.apache.zookeeper</groupId>
  <artifactId>zookeeper</artifactId>
  <version>${zookeeper-version}</version>
  <exclusions>
    <exclusion>
      <groupId>ch.qos.logback</groupId>
      <artifactId>logback-classic</artifactId>
    </exclusion>
  </exclusions>
</dependency>

[rafvasq]

In case you missed it, please revert slf4j-version too and hopefully the tests pass.

[israel-hdez]

In case you missed it, please revert slf4j-version too and hopefully the tests pass.

@rafvasq I just updated the PR. Looks like it is working :-)

[rafvasq]

/lgtm

[oss-prow-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rafvasq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment