Skip to content

Commit

Permalink
fix: Ensure intra-cluster InternalExceptions are propagated properly
Browse files Browse the repository at this point in the history
Motivation

In certain error edge cases, InternalExceptions can be thrown on the inferencing path, but these currently don't propagate properly because they aren't declared to be thrown by the internal thrift applyModel(Multi) method. Because of this, they are treated as generic errors meaning that the error detail (message) is lost and when returned to the user can have a confusing message like "Nowhere available to load".

Modifications

- Add InternalException to internal applyModel thrift rpc method definitions
- Also update to use latest version of thrift

Result

InternalExceptions will propagate properly between modelmesh pods

Signed-off-by: Nick Hill <nickhill@us.ibm.com>
  • Loading branch information
njhill committed Oct 3, 2022
1 parent cdd995d commit 4cfdf2e
Show file tree
Hide file tree
Showing 3 changed files with 265 additions and 18 deletions.
7 changes: 7 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
<guava-version>31.1-jre</guava-version>
<jackson-databind-version>2.13.4</jackson-databind-version>
<gson-version>2.9.1</gson-version>
<thrift-version>0.16.0</thrift-version>
<eclipse-collections-version>11.1.0</eclipse-collections-version>
<log4j2-version>2.19.0</log4j2-version>
<slf4j-version>1.7.36</slf4j-version>
Expand Down Expand Up @@ -516,6 +517,12 @@
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<!-- override litelinks' version with latest -->
<groupId>org.apache.thrift</groupId>
<artifactId>libthrift</artifactId>
<version>${thrift-version}</version>
</dependency>
</dependencies>
</dependencyManagement>
</project>
Loading

0 comments on commit 4cfdf2e

Please sign in to comment.