Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update MLServer to v1.3.2 #355

Merged
merged 18 commits into from
May 27, 2023
Merged

chore: Update MLServer to v1.3.2 #355

merged 18 commits into from
May 27, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Apr 13, 2023 •
edited
Loading

Depends on runtime-adapter's #45.

Motivation

The default MLServer serving runtime in ModelMesh hasn't been updated for a while and KServe recently updated to MLServer v1.3.2.

Modifications

  • MLServer image version in the default serving runtime and FVTs were updated from 0.5.2 to 1.3.2
  • Filenames were modified for the update

Result

@rafvasq rafvasq changed the title chore: Bump mlserver to v1.2.4 chore: Update MLServer to v1.2.4 Apr 13, 2023
@ckadner ckadner added this to the v0.11.0 milestone Apr 14, 2023
rafvasq added 4 commits April 14, 2023 14:03
@rafvasq
chore: Bump mlserver to v1.2.4
e34b4ff 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
Rename runtime yaml
af1f801 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
Updates refs from 0.x to 1.x
44cad0d 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
Updates expected error message
a7d6a19 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
Updates another error output
584e8ed 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq rafvasq marked this pull request as ready for review April 14, 2023 20:16
rafvasq added 2 commits April 17, 2023 09:59
@rafvasq
Updates 0.x to 1.x
d62b695 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
Lints
8b1b369 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq rafvasq marked this pull request as draft April 18, 2023 20:00
@rafvasq rafvasq mentioned this pull request Apr 25, 2023
Merged
rafvasq added 2 commits April 25, 2023 15:43
@rafvasq
test adapter
d97e657 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
test adapter
e1c45bb 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
rafvasq added 4 commits April 26, 2023 10:15
@rafvasq
increase timeout for fvt
6a5ba9b 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
pull dev runtime-adapter
711fa61 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
Revert to kserve adapter
2e4a0ac 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
Revert timeout
8c406b6 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq rafvasq marked this pull request as ready for review April 27, 2023 18:30
@rafvasq rafvasq requested a review from ckadner April 27, 2023 18:30
@rafvasq rafvasq marked this pull request as draft May 2, 2023 19:54
@rafvasq rafvasq marked this pull request as ready for review May 16, 2023 19:49
rafvasq added 2 commits May 16, 2023 15:54
@rafvasq
Merge branch 'main' of https://github.com/kserve/modelmesh-serving in…
0a70d9b 
…to update-mlserver
@rafvasq
Update hpa_test to find 1.x
ed1f935 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@ckadner
Copy link
Member

ckadner commented May 18, 2023 •
edited
Loading

Hi Rafael, I noticed KServe recently updated to MLServer v1.3.2.

I know you put a lot of effort into this update, but since you already identified many of the breaking points, should we use this opportunity to go to 1.3.2 to be inline with KServe proper?

@rafvasq
Copy link
Member Author

rafvasq commented May 19, 2023

@ckadner thanks for pointing that out! I think so. Looks like MLServer released 1.3.0 just a couple of weeks after I opened this 😅

rafvasq added 2 commits May 23, 2023 11:29
@rafvasq
Update to 1.3.2
7e551ee 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq
Lints
a1e56f0 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq rafvasq changed the title chore: Update MLServer to v1.2.4 chore: Update MLServer to v1.3.2 May 23, 2023
kserve-oss-bot pushed a commit to kserve/modelmesh-runtime-adapter that referenced this pull request May 26, 2023
@rafvasq
chore: Update MLServer protobuf (#45)
f9dc1dc 
#### Motivation

Related to [updating the MLServer runtime image](kserve/modelmesh-serving#355), the `ModelRepository` endpoint was deprecated. 

References:
kserve/modelmesh-serving#159
SeldonIO/MLServer#616

#### Modifications
- Updated protobuf 
- Updated mock server testing
- Updated runtime-adapter code to call new endpoint

#### Result
- MLServer runtime adapter no longer uses the deprecated model repository API

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@ckadner
Copy link
Member

ckadner commented May 26, 2023

kserve/modelmesh-runtime-adapter#45 is merged

@ckadner
Copy link
Member

ckadner commented May 26, 2023

@rafvasq could you update this PR once more to get a build and full test run with the updated runtime adapter code?

@rafvasq
Copy link
Member Author

rafvasq commented May 26, 2023

@ckadner all done!

@rafvasq rafvasq mentioned this pull request May 26, 2023
Merged
ckadner
ckadner approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner, rafvasq
To complete the pull request process, please assign tjohnson31415 after the PR has been reviewed.
You can assign the PR to them by writing /assign @tjohnson31415 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit b9800fa into kserve:main May 27, 2023
lgdeloss pushed a commit to lgdeloss/modelmesh-serving that referenced this pull request Jun 5, 2023
@rafvasq @lgdeloss
chore: Update MLServer to v1.3.2 (kserve#355)
5bf1ec2 
Update MLServer image for the default serving runtime from 0.5.2 to 1.3.2

Depends on kserve/modelmesh-runtime-adapter#45

Closes kserve#357

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Luis Delossantos <luisgd@ibm.com>
lgdeloss pushed a commit to lgdeloss/modelmesh-serving that referenced this pull request Jun 6, 2023
@rafvasq @lgdeloss
chore: Update MLServer to v1.3.2 (kserve#355)
56b4c7a 
Update MLServer image for the default serving runtime from 0.5.2 to 1.3.2

Depends on kserve/modelmesh-runtime-adapter#45

Closes kserve#357

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Luis Delossantos <luisgd@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckadner ckadner ckadner approved these changes

@njhill njhill Awaiting requested review from njhill

@tjohnson31415 tjohnson31415 Awaiting requested review from tjohnson31415

Assignees

@ckadner ckadner

Labels
lgtm
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Update MLServer serving runtime image
3 participants
@rafvasq @ckadner @kserve-oss-bot