Merge latest changes from main
#305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Motivation Fix vulnerabilities in the ModelMesh Controller image. #### Modifications 1. Remove dependencies to any packages in the runtime. 2. Updated Go version to the latest version. #### Result The feature is functionally working, I have tested it on my own cluster. Signed-off-by: JasmondL <Jasmond.Ming.Quan.Loh@sap.com> Co-authored-by: JasmondL <Jasmond.Ming.Quan.Loh@sap.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
#### Motivation Quickstart should use namespace scope mode for simplicity. In current version there is an inconsistency wrt `ServingRuntimes` vs `ClusterServingRuntimes`. #### Modifications - `docs/install/install-script.md` (correct a typo) - `docs/quickstart.md` (change install command for ns scope mode and add missing `torchserv` serving runtime) - `scripts/install.sh` (fix `sed -i` commands) #### Result Quickstart install steps work like a charm again :-) #### TODOs Once merged into `main`, we will need to update the `release-0.10` branch as well --- /cc @njhill /assign @njhill Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ckadner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This merge is not ideal as there are some commits here that were merged before. |
|
OK @ckadner I'm closing this since I've just cherry-picked/pushed that one commit to the |
hdefazio
pushed a commit
to hdefazio/modelmesh-serving
that referenced
this pull request
Feb 14, 2025
Signed-off-by: mholder6 <marholde@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
release-0.10branch with last commits frommain(#304)/cc @njhill