-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add script to identify broken doc links #237
Conversation
* Find all Markdown files in the project * Extract all Markdown-style links and plain URLs * Create unique list of simplified URLs * Use local files to check relative links, use cached HTTP requests for links outside project * Run HTTP requests in parallel * Retry GitHub rate-limited URLs after (at least) one minute * Report broken links with source file and line number Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
* Remove inactive docs and docs.dev targets Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* Use config/ as the manifests source for ODH operator v2 Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * move all changes into an overlay Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * restructure manifests so that kustomize does not need LoadRestrictorNone flag Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * correct label mismatch Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * final modifications Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * remove openvino variable as it is unused Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> --------- Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
* Manifest readiness for Operator v2 (kserve#237) * Use config/ as the manifests source for ODH operator v2 Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * move all changes into an overlay Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * restructure manifests so that kustomize does not need LoadRestrictorNone flag Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * correct label mismatch Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * final modifications Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * remove openvino variable as it is unused Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> --------- Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * change image tags to 0.11.1 Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> --------- Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Motivation
Broken links in documentation are making it harder for new comers to learn about ModelMesh and often it is not easy to find what the correct link should be. For project maintainers it is time consuming to revisit documentation to identify broken links manually and it certainly does not make the best impression on new comers if they click on links that return 404 errors.
Modifications
Add new script
scripts/verify_doc_links.py
and newMake
targetcheck-doc-links
to identify broken links in any of the currently 211 links in 43 Markdown files.Result
And after fixing the broken links:
How does the script work
Script pedigree: I contributed several iteration of this script to MLX and KFP-Tekton projects. This one differs in that it does not require any non-standard libraries like for Markdown or
requests
to be installed into a virtual environment prior to running the script.Possible future enhancements
Add a new Pull Request builder check to run the
check-doc-links
frequently and fix broken links as soon as possible./cc @njhill @chinhuang007