Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update FVT prerequisites #235

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Sep 8, 2022

Motivation

After many attempts to run the FVT tests it became clear that an undersized Kubernetes cluster (insufficient resources) prevented the FVTs to succeed.

Modifications

Update the FVT README with a Prerequisite section that outlines the required CLIs and the minimum cluster size.

Result

The FVT tests completed successfully.

/cc @njhill @chinhuang007

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner
To complete the pull request process, please assign animeshsingh after the PR has been reviewed.
You can assign the PR to them by writing /assign @animeshsingh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner added documentation Improvements or additions to documentation test testing related bugs and fixes labels Sep 8, 2022
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner force-pushed the doc_update_fvt_prereqs branch from 2b4fd47 to 24c30d1 Compare September 8, 2022 22:49
@njhill
Copy link
Member

njhill commented Sep 9, 2022

@ckadner there's a linter failure, you need to run make fmt which will fail the first time but make the required formatting changes. So running a second time should pass and you can then commit those changes.

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Copy link
Member Author

ckadner commented Sep 9, 2022

@ckadner there's a linter failure, you need to run make fmt which will fail the first time but make the required formatting changes. So running a second time should pass and you can then commit those changes.

Thanks @njhill -- I am too used to my IDE doing the code cleanup for me

@njhill
Copy link
Member

njhill commented Sep 9, 2022

/lgtm

@njhill njhill merged commit b45420d into kserve:main Sep 9, 2022
@ckadner
Copy link
Member Author

ckadner commented Sep 9, 2022

Thanks Nick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm test testing related bugs and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants