Fix script for push latest image #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix script for push latest image issue, unable to install jq
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chinhuang007, pvaneck The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KimSoungRyoul
pushed a commit
to KimSoungRyoul/modelmesh-serving
that referenced
this pull request
Dec 28, 2022
* KServe Go module and API group change -------------------------------------- Updated go source files with new go module. Changed apigroup in yaml files. Made changes in Makefile to represent the repository and apigroup names. Verified `make test` is passing. Removed reference for old names. * Pointed correct repo reference for ko images (kserve#23) * Rename changes python - New (kserve#19) * python changes-initial-commit * updated api gen. Renamed package references in python. * Renamed python/kfserving to python/kserve * renamed python folder according to package kserve * Ran client-gen. Updated swagger.json * renamed constants from KFSERVING_ to KSERVE_. Yet to change namespace from kfserving-system to kserve and hence not changed in python side. * Updated kfserving reference to kserve Updated version for Python Package Index to 0.7.0rc0 Renamed KFServingSampleModel to KServeSampleModel * Python package and corresponding directory change has to be reflected in test and dockerfiles * updated a specific version in requirments to address issue with pip resolver. Added more specific versions in requirements,txt and updated paddleserver setup.py with kserve dependency. * Changed namespace from kfserving-system to kserve (kserve#31) * Update local dev scripts (kserve#33) * initial commit of dev-scripts update * Updated quick-install * Updated python Makefile * Generated install for new release * Updated generate-install script with new release * Reverting controller name in makefile. Will be updated in separate pr. * Github action changes (kserve#34) * Github action changes Migrated images publish to kserve repo. Added github workflows for the ones that was being pushed to gcr.io from release/triggers. * Removed batcher publisher since batcher.Dockerfile does not exist Updated tf2openapi.Dockerfile to correct directory and package. * Fixed issue with working directory of tf2openapi workflow * Removed the deptrecated logger docker * Excluded tests from linting. (kserve#36) They were pointing to older directory and package names and hence were not being excluded while linting. * Update license (kserve#20) * Fixed errors thrown by flake8 linter (kserve#37) * Kfserving kserve manifests changes and code reference changes (kserve#39) * kfserving -> kserve migartion initial commit * kfserving -> kserve config changes * Changed constants. Updated image reference from kserve to andyarok * Reverted kserve models web app image repo. * go changes for kfserving-kserve * Updated KFServing refernce in python code * Updated KFServing to KServe in python doc comments. Updated references of v1alpha2 from duplicate aliases to just use pkg name. Updated docs samples references with proper name. Made changes to use Constant for container name instead of literal "kserve-container". * Updated gitignore for generated files that came in after folder rename. Removed the generated files. Fixed lint warnings for go. * Removed travis yml file. * KServe doc update (kserve#38) * Update main and pythonserver readme * Update python docs * Fix role binding * Update kserve sdk doc * Fix e2e test script * Fix import * Kserve error fix (kserve#40) * Fixed linting errors in python * Fixed make test. Issue with storage initializer name/path. * Fixed failing python test. Updated ray version. Updated KFServingClient reference to KServeClient in kserve init. * Updated ray version from 1.4.0 to 1.5.0 * Fixed error with e2e due to kfserving reference in test overlay (kserve#42) Updated quick install and added 0.7.0-rc0 install manifests. Updated e2e namespace. * Controller repo update (kserve#45) Made changes in workflow to update image repo to kserve instead of kfserving * Controller repo update (kserve#45) Made changes in workflow to update image repo to kserve instead of kfserving * update pytorch image * Fix transformer dockerfile Co-authored-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: andyi2it <87992092+andyi2it@users.noreply.github.com>
KimSoungRyoul
pushed a commit
to KimSoungRyoul/modelmesh-serving
that referenced
this pull request
Dec 28, 2022
* KServe Go module and API group change -------------------------------------- Updated go source files with new go module. Changed apigroup in yaml files. Made changes in Makefile to represent the repository and apigroup names. Verified `make test` is passing. Removed reference for old names. * Pointed correct repo reference for ko images (kserve#23) * Rename changes python - New (kserve#19) * python changes-initial-commit * updated api gen. Renamed package references in python. * Renamed python/kfserving to python/kserve * renamed python folder according to package kserve * Ran client-gen. Updated swagger.json * renamed constants from KFSERVING_ to KSERVE_. Yet to change namespace from kfserving-system to kserve and hence not changed in python side. * Updated kfserving reference to kserve Updated version for Python Package Index to 0.7.0rc0 Renamed KFServingSampleModel to KServeSampleModel * Python package and corresponding directory change has to be reflected in test and dockerfiles * updated a specific version in requirments to address issue with pip resolver. Added more specific versions in requirements,txt and updated paddleserver setup.py with kserve dependency. * Changed namespace from kfserving-system to kserve (kserve#31) * Update local dev scripts (kserve#33) * initial commit of dev-scripts update * Updated quick-install * Updated python Makefile * Generated install for new release * Updated generate-install script with new release * Reverting controller name in makefile. Will be updated in separate pr. * Github action changes (kserve#34) * Github action changes Migrated images publish to kserve repo. Added github workflows for the ones that was being pushed to gcr.io from release/triggers. * Removed batcher publisher since batcher.Dockerfile does not exist Updated tf2openapi.Dockerfile to correct directory and package. * Fixed issue with working directory of tf2openapi workflow * Removed the deptrecated logger docker * Excluded tests from linting. (kserve#36) They were pointing to older directory and package names and hence were not being excluded while linting. * Update license (kserve#20) * Fixed errors thrown by flake8 linter (kserve#37) * Kfserving kserve manifests changes and code reference changes (kserve#39) * kfserving -> kserve migartion initial commit * kfserving -> kserve config changes * Changed constants. Updated image reference from kserve to andyarok * Reverted kserve models web app image repo. * go changes for kfserving-kserve * Updated KFServing refernce in python code * Updated KFServing to KServe in python doc comments. Updated references of v1alpha2 from duplicate aliases to just use pkg name. Updated docs samples references with proper name. Made changes to use Constant for container name instead of literal "kserve-container". * Updated gitignore for generated files that came in after folder rename. Removed the generated files. Fixed lint warnings for go. * Removed travis yml file. * KServe doc update (kserve#38) * Update main and pythonserver readme * Update python docs * Fix role binding * Update kserve sdk doc * Fix e2e test script * Fix import * Kserve error fix (kserve#40) * Fixed linting errors in python * Fixed make test. Issue with storage initializer name/path. * Fixed failing python test. Updated ray version. Updated KFServingClient reference to KServeClient in kserve init. * Updated ray version from 1.4.0 to 1.5.0 * Fixed error with e2e due to kfserving reference in test overlay (kserve#42) Updated quick install and added 0.7.0-rc0 install manifests. Updated e2e namespace. * Controller repo update (kserve#45) Made changes in workflow to update image repo to kserve instead of kfserving * Controller repo update (kserve#45) Made changes in workflow to update image repo to kserve instead of kfserving * update pytorch image * Fix transformer dockerfile Co-authored-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: andyi2it <87992092+andyi2it@users.noreply.github.com>
KimSoungRyoul
pushed a commit
to KimSoungRyoul/modelmesh-serving
that referenced
this pull request
Dec 28, 2022
…-gh-action Introduce a GH action for flake8
hdefazio
pushed a commit
to hdefazio/modelmesh-serving
that referenced
this pull request
Jan 16, 2025
Solve conflict commits for 0.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix script for push latest image issue, unable to install jq
Motivation
Fix the issue for push latest image where it is unable to install jq
Modifications
Add apt update to download package information from all configured sources before apt install
Result
jq is installed, and the latest image is pushed to Docker Hub as needed.