Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Sync updated model-runtime.proto file from modelmesh repo #203

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

njhill
Copy link
Member

@njhill njhill commented Aug 1, 2022

Motivation

The docs dir in this repo contains a copy of the model-runtime.proto service definition from the model-mesh repo. It was recently updated with clearer comments for a couple of the RPC methods.

Modifications

Sync the latest version to this repo.

Signed-off-by: Nick Hill nickhill@us.ibm.com

Motivation

The docs dir in this repo contains a copy of the model-runtime.proto service definition from the model-mesh repo. It was recently updated with clearer comments for a couple of the RPC methods.

Modifications

Sync the latest version to this repo.

Signed-off-by: Nick Hill <nickhill@us.ibm.com>
@njhill njhill added the documentation Improvements or additions to documentation label Aug 1, 2022
Copy link
Contributor

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing detailed comments, @njhill!

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chinhuang007, njhill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chinhuang007
Copy link
Contributor

/lgtm

@kserve-oss-bot kserve-oss-bot merged commit c79fa0a into main Aug 2, 2022
@njhill njhill deleted the proto-doc branch August 8, 2022 18:35
hdefazio pushed a commit to hdefazio/modelmesh-serving that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants