Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVC support follow up items #337

Closed
3 of 6 tasks
ckadner opened this issue Mar 1, 2023 · 0 comments · Fixed by #340
Closed
3 of 6 tasks

PVC support follow up items #337

ckadner opened this issue Mar 1, 2023 · 0 comments · Fixed by #340
Assignees
@ckadner
Labels
documentation Improvements or additions to documentation enhancement New feature or request test testing related bugs and fixes
Milestone
v0.11.0

Comments

@ckadner
Copy link
Member

ckadner commented Mar 1, 2023 •
edited
Loading

Follow up items for PVC Storage Support (#267):

  • Add FVT test case
  • Add doc describing options to enable PVC support
  • A new Predictor with invalid PVC should not "crash" serving pods
  • Don't require the storage-config Secret if allowAnyPVC is enabled (Feat: Add PVC storage support #267 (comment))
  • Adding multiple PVCs to storage-config causes runtime deployments to become unstable
  • Adding Predictor/ISVC with model on a PVC that is not in the storage-config secret and allowAnyPVC enabled will cause the Predictor/ISVC to land on an old runtime pod that does not yet have the PVC mounted

Resolved by #340
@ckadner ckadner self-assigned this Mar 1, 2023
@ckadner ckadner added documentation Improvements or additions to documentation enhancement New feature or request test testing related bugs and fixes labels Mar 1, 2023
@ckadner ckadner added this to the v0.11.0 milestone Mar 1, 2023
@ckadner ckadner mentioned this issue Mar 14, 2023
Merged
njhill pushed a commit that referenced this issue Mar 21, 2023
@ckadner
Bug fixes and E2E tests for PVC storage (#340)
3f01857 
Motivation

Address PVC follow-up work items outlined in #337 for PVC storage introduced in #267

Modifications

Code changes:
- Sort PVC mounts on serving runtime specs to avoid unstable repeated
runtime rollouts as Kubernetes treat two otherwise identical deployment
specs as different if the same set of volume mounts are in different order
- Don't add non-existent PVCs from predictor/ISVC when allowAnyPVC is
enabled as this would cause all serving pods for that runtime to stay in
- Pending state with unbound (pending) volumes
- Tolerate missing storage-config secret when allowAnyPVC is enabled
- Lint: fix "io/ioutil" deprecations

FVT changes:
- Add Storage test suite
- Add helper methods to add PVC to storage-config during FVT
- Allow for additional time in WaitForReadyDeployStatus but allow early abort on success
- Check if pod still running before gRPC/REST requests, reconnect if necessary
- Only choose "Ready" runtime pod for port-forwards
- Include ISVC tests in Predictor test suite to ensure "serial" execution of TLS tests

Resolves #337

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner mentioned this issue Mar 23, 2023
Merged
19 tasks
ckadner added a commit that referenced this issue Mar 23, 2023
@ckadner
Prepare v0.11.0-alpha tech preview release
d154ae8 
- PVC storage support (#230, #337) 
- Payload logging/events (#284)

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
VedantMahabaleshwarkar pushed a commit to VedantMahabaleshwarkar/modelmesh-serving that referenced this issue Mar 23, 2023
@ckadner @VedantMahabaleshwarkar
Bug fixes and E2E tests for PVC storage (kserve#340)
0d0a9f7 
Motivation

Address PVC follow-up work items outlined in kserve#337 for PVC storage introduced in opendatahub-io#267

Modifications

Code changes:
- Sort PVC mounts on serving runtime specs to avoid unstable repeated
runtime rollouts as Kubernetes treat two otherwise identical deployment
specs as different if the same set of volume mounts are in different order
- Don't add non-existent PVCs from predictor/ISVC when allowAnyPVC is
enabled as this would cause all serving pods for that runtime to stay in
- Pending state with unbound (pending) volumes
- Tolerate missing storage-config secret when allowAnyPVC is enabled
- Lint: fix "io/ioutil" deprecations

FVT changes:
- Add Storage test suite
- Add helper methods to add PVC to storage-config during FVT
- Allow for additional time in WaitForReadyDeployStatus but allow early abort on success
- Check if pod still running before gRPC/REST requests, reconnect if necessary
- Only choose "Ready" runtime pod for port-forwards
- Include ISVC tests in Predictor test suite to ensure "serial" execution of TLS tests

Resolves kserve#337

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
VedantMahabaleshwarkar pushed a commit to VedantMahabaleshwarkar/modelmesh-serving that referenced this issue Mar 23, 2023
@ckadner @VedantMahabaleshwarkar
Bug fixes and E2E tests for PVC storage (kserve#340)
ffba751 
Motivation

Address PVC follow-up work items outlined in kserve#337 for PVC storage introduced in opendatahub-io#267

Modifications

Code changes:
- Sort PVC mounts on serving runtime specs to avoid unstable repeated
runtime rollouts as Kubernetes treat two otherwise identical deployment
specs as different if the same set of volume mounts are in different order
- Don't add non-existent PVCs from predictor/ISVC when allowAnyPVC is
enabled as this would cause all serving pods for that runtime to stay in
- Pending state with unbound (pending) volumes
- Tolerate missing storage-config secret when allowAnyPVC is enabled
- Lint: fix "io/ioutil" deprecations

FVT changes:
- Add Storage test suite
- Add helper methods to add PVC to storage-config during FVT
- Allow for additional time in WaitForReadyDeployStatus but allow early abort on success
- Check if pod still running before gRPC/REST requests, reconnect if necessary
- Only choose "Ready" runtime pod for port-forwards
- Include ISVC tests in Predictor test suite to ensure "serial" execution of TLS tests

Resolves kserve#337

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
VedantMahabaleshwarkar pushed a commit to VedantMahabaleshwarkar/modelmesh-serving that referenced this issue Mar 23, 2023
@ckadner @VedantMahabaleshwarkar
Bug fixes and E2E tests for PVC storage (kserve#340)
abba37e 
Motivation

Address PVC follow-up work items outlined in kserve#337 for PVC storage introduced in opendatahub-io#267

Modifications

Code changes:
- Sort PVC mounts on serving runtime specs to avoid unstable repeated
runtime rollouts as Kubernetes treat two otherwise identical deployment
specs as different if the same set of volume mounts are in different order
- Don't add non-existent PVCs from predictor/ISVC when allowAnyPVC is
enabled as this would cause all serving pods for that runtime to stay in
- Pending state with unbound (pending) volumes
- Tolerate missing storage-config secret when allowAnyPVC is enabled
- Lint: fix "io/ioutil" deprecations

FVT changes:
- Add Storage test suite
- Add helper methods to add PVC to storage-config during FVT
- Allow for additional time in WaitForReadyDeployStatus but allow early abort on success
- Check if pod still running before gRPC/REST requests, reconnect if necessary
- Only choose "Ready" runtime pod for port-forwards
- Include ISVC tests in Predictor test suite to ensure "serial" execution of TLS tests

Resolves kserve#337

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckadner ckadner

Labels
documentation Improvements or additions to documentation enhancement New feature or request test testing related bugs and fixes
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

Bug fixes and E2E tests for PVC storage ckadner/modelmesh-serving
1 participant
@ckadner