Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GKE): Update documentation about calling inference service endpoing behind IAP. Fix https://github.com/kubeflow/gcp-blueprints/issues/324 #1832

Merged
merged 4 commits into from
Sep 26, 2021

Conversation

zijianjoy
Copy link
Contributor

@zijianjoy zijianjoy commented Sep 25, 2021

What this PR does / why we need it:

Validated that GCP IAP instruction here is working with Kubeflow 1.4 release.

Related GitHub issues:

fixes #1660
#913
#1660
#1199

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes GoogleCloudPlatform/kubeflow-distribution#324

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

No change

Release note:

NONE

@aws-kf-ci-bot
Copy link
Contributor

Hi @zijianjoy. Thanks for your PR.

I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/samples/gcp-iap/README.md Outdated Show resolved Hide resolved
docs/samples/gcp-iap/sklearn-iap-with-authz.yaml Outdated Show resolved Hide resolved
docs/samples/gcp-iap/sklearn-iap-with-authz.yaml Outdated Show resolved Hide resolved
docs/samples/gcp-iap/sklearn-iap-no-authz.yaml Outdated Show resolved Hide resolved
@yuzisun
Copy link
Member

yuzisun commented Sep 26, 2021

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuzisun, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Copy link
Member

yuzisun commented Sep 26, 2021

/lgtm

thanks @zijianjoy !

@yuzisun
Copy link
Member

yuzisun commented Sep 26, 2021

/ok-to-test

@kserve-oss-bot kserve-oss-bot merged commit dd5908b into kserve:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants