Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind events #39

Merged
merged 2 commits into from
Sep 30, 2013
Merged

Unbind events #39

merged 2 commits into from
Sep 30, 2013

Conversation

maplemuse
Copy link
Contributor

This addresses #38 by ensuring that events are properly unbound on shutdown.

I updated the many-series example page to better show the before/after results.
Load the page, perform a heap snapshot in Chrome. Click the replot link, then perform a second heap snapshot.
Finally, click again, perform a third heap snapshot. Select the third snapshot, and select items created between snapshots 1 and 2.
Before the second commit, you will see that the plot tooltip plot hover event handlers remain, leaking memory.

@maplemuse
Copy link
Contributor Author

I've done further changes as well which get much more drastic. I changed from the prototype.init code that was there previously to the shorter, simpler nested functions. I didn't add this to the pull request yet, as it's a much more drastic change.

@krzysu
Copy link
Owner

krzysu commented Aug 20, 2013

just remember that the tooltip needs to support multiple instances :)

@maplemuse
Copy link
Contributor Author

My primary environment is a web dashboard with six plots, updating with new data frequently.

krzysu pushed a commit that referenced this pull request Sep 30, 2013
@krzysu krzysu merged commit 33610a0 into krzysu:master Sep 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants