Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #92: remove workaround and apply startupAttempts to containers #93

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Apr 26, 2023

testcontainers/testcontainers-java#6667 has been resolved and we've already adopted the release. We can remove the createNetwork() workaround and apply the startupAttempts to the containers to workaround any podman jitters.

…ontainers

Signed-off-by: kwall <kwall@apache.org>
Copy link
Member

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle, will test tomorrow

Copy link
Member

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and have stopped seeing the failures associated with this.

@SamBarker SamBarker merged commit d5f980a into kroxylicious:main Apr 26, 2023
@k-wall k-wall deleted the issue-92 branch April 27, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants