feat(Table): support providing selected rows to sync with external model #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
623371c to
9b3d779
Compare
meriouma
commented
Dec 12, 2024
| @@ -410,7 +417,7 @@ export const Table = <T extends object>({ | |||
| rowNumbers, | |||
| providedColumns, | |||
| ariaLabelledByColumnId, | |||
| expandChildsOnRowSelection, | |||
| expandChildrenOnRowSelection, | |||
There was a problem hiding this comment.
C'est breaking juste pour la version snapshot.
meriouma
commented
Dec 12, 2024
| @@ -671,7 +673,7 @@ export const MultipleSelectableExpandableSubRows: Story = { | |||
| }, | |||
| ]; | |||
|
|
|||
| const data: TableData<ExpandableData>[] = [ | |||
| const data: TableData<ExpandableData>[] = useMemo(() => [ | |||
There was a problem hiding this comment.
Petit détail nécessaire dans la story, sinon le data change d'instance à chaque render.
|
Storybook for this build: https://ds.equisoft.io/pr-1055/ |
|
Webapp for this build: https://ds.equisoft.io/pr-1055/webapp/ |
meriouma
commented
Dec 12, 2024
| @@ -32,40 +53,6 @@ export function calculateStickyHeader( | |||
| }); | |||
| } | |||
|
|
|||
| export function calculateStickyFooter( | |||
There was a problem hiding this comment.
Je sais pas pourquoi mais ces 2 fonctions n'étaient plus utilisées
pylafleur
reviewed
Dec 12, 2024
savutsang
reviewed
Dec 13, 2024
savutsang
reviewed
Dec 13, 2024
…th external model
…sync with external model
…ows to sync with external model
…ected rows to sync with external model
…ing selected rows to sync with external model
…th external model
…sync with external model
…ows to sync with external model
…ected rows to sync with external model
7dc8ede to
5cb7421
Compare
pylafleur
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.