feat(math): implement field extension for stark fields #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69ab1b7 to
95bce9a
Compare
fakedev9999
reviewed
Jun 21, 2024
2dfc32b to
a45cdaa
Compare
a45cdaa to
214f39f
Compare
fakedev9999
reviewed
Jun 24, 2024
fakedev9999
reviewed
Jun 24, 2024
fakedev9999
reviewed
Jun 24, 2024
214f39f to
d3659e7
Compare
ashjeong
reviewed
Jun 24, 2024
tachyon/math/finite_fields/generator/ext_prime_field_generator/build_defs.bzl
Show resolved
Hide resolved
d3659e7 to
081fa8d
Compare
ashjeong
reviewed
Jun 25, 2024
081fa8d to
b178601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements some parts of the BinomialExtensionField, which are missing in Tachyon, specifically,
QuarticExtension.You might need https://eprint.iacr.org/2006/471.pdf to review the multiplication and square calculations. Use https://blkcipher.pl/assets/pdfs/Handbook_of_Elliptic_and_Hyperelliptic_Curve_Cryptography.pdf to review the inversion calculations.