Skip to content

Commit

Permalink
refac(math): follow constant naming convention
Browse files Browse the repository at this point in the history
  • Loading branch information
chokobole committed Jun 24, 2024
1 parent 976c85b commit 68e4eb5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions tachyon/math/finite_fields/cubic_extension_field.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@ class CubicExtensionField : public CyclotomicMultiplicativeSubgroup<Derived> {
static Derived FromBasePrimeFields(
absl::Span<const BasePrimeField> prime_fields) {
CHECK_EQ(prime_fields.size(), ExtensionDegree());
constexpr size_t base_field_degree = BaseField::ExtensionDegree();
if constexpr (base_field_degree == 1) {
constexpr size_t kBaseFieldDegree = BaseField::ExtensionDegree();
if constexpr (kBaseFieldDegree == 1) {
return Derived(prime_fields[0], prime_fields[1], prime_fields[2]);
} else {
BaseField c0 = BaseField::FromBasePrimeFields(
prime_fields.subspan(0, base_field_degree));
prime_fields.subspan(0, kBaseFieldDegree));
BaseField c1 = BaseField::FromBasePrimeFields(
prime_fields.subspan(base_field_degree, base_field_degree));
prime_fields.subspan(kBaseFieldDegree, kBaseFieldDegree));
BaseField c2 = BaseField::FromBasePrimeFields(
prime_fields.subspan(2 * base_field_degree, base_field_degree));
prime_fields.subspan(2 * kBaseFieldDegree, kBaseFieldDegree));
return Derived(std::move(c0), std::move(c1), std::move(c2));
}
}
Expand Down
8 changes: 4 additions & 4 deletions tachyon/math/finite_fields/quadratic_extension_field.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ class QuadraticExtensionField
static Derived FromBasePrimeFields(
absl::Span<const BasePrimeField> prime_fields) {
CHECK_EQ(prime_fields.size(), ExtensionDegree());
constexpr size_t base_field_degree = BaseField::ExtensionDegree();
if constexpr (base_field_degree == 1) {
constexpr size_t kBaseFieldDegree = BaseField::ExtensionDegree();
if constexpr (kBaseFieldDegree == 1) {
return Derived(prime_fields[0], prime_fields[1]);
} else {
BaseField c0 = BaseField::FromBasePrimeFields(
prime_fields.subspan(0, base_field_degree));
prime_fields.subspan(0, kBaseFieldDegree));
BaseField c1 = BaseField::FromBasePrimeFields(
prime_fields.subspan(base_field_degree));
prime_fields.subspan(kBaseFieldDegree));
return Derived(std::move(c0), std::move(c1));
}
}
Expand Down

0 comments on commit 68e4eb5

Please sign in to comment.