avoid recursion when packing with toJSON #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons outside of my control, someone might return `this` when implementing `toJSON` causing the packing logic to go into an infinite loop. This commit implements a guard against this specific case. The logic will continue through if `value.toJSON() === value`.
|
It would greatly help if this was released as a patch release. |
kriszyp
approved these changes
Jun 6, 2023
|
Thank you for the PR! Published in 1.9.5. |
I don't have super useful feedback other than that I don't know why it was introduced, and the issue fixed by this PR isn't really a showstopper but rather what feels like some odd corner case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons outside of my control, someone might return
thiswhen implementingtoJSONcausing the packing logic to go into an infinite loop.This commit implements a guard against this specific case. The logic will continue through if
value.toJSON() === value.