-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bare minimum Redux integration #883
Conversation
6149ef2
to
b797e80
Compare
This should be the default setup for RSK, in my opinion. Passing data from server to client feels sloppy without at least a minimum redux store such as this. |
Hi @koistya, thanks for all the hard work on this project! I have a quick question regarding this PR. In the react-intl branch, the initial state is assigned using the following:
However, in this PR, you serialize it instead of stringify:
Then both methods fetch it in client.js. I can see how both work, I was just wondering if there is a preferred approach and what the pros/cons are? Many thanks! |
This would be great. @koistya what is the status of this? |
@jwhchambers deserializing data from a |
I just Integrated this PR into |
@koistya thank you very much for this PR! Unfortunately, we have close it due to inactivity. Feel free to re-open it or join our Discord channel for discussion. NOTE: The |
Next steps
core/createStore.js
connect(..)
middleware from thereact-redux
packageFor more information visit
How to Merge
Ref #753, #738, #612, #173.