-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix php_pcre_match_impl with 8.4 #111
Conversation
works good, let's get it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @remicollet!
Works on Windows (MSVC), too. |
Hey @remicollet thanks for the PR for PHP 8.4 support. Do you have a timeline for merging / releasing this PR? Will you wait until PHP 8.4 RC1 or GA? |
I always consider it strange to release a new version, stating "Compatible with 8.4" during alpha/beta, which does not have the Final API. So yes, I think it is better to wait for RC1. BTW, the decision is to the owner, so to @krakjoe |
API bump/fix will happen in 2 weeks with RC1, this is only fix required to work on 8.4 so better to wait final polishing |
RC1 is out and API finally fixed, used to rebuild with this patch and no issues detected |
Joe Watkins aka I encourage you to check out the GoFundMe campaign https://gofund.me/8b6df24f. Additionally, sharing the story within your networks can help raise awareness and support. Thank you for taking the time to read this and for any support you can provide! |
There is no more E_STRICT for error_reporting, and session.sid_length is gone. The imap extension has moved to PECL. No blackfire or newrelic extension builds yet with support for 8.4. The phalcon extension is incompatible with 8.4 (they always get new releases some time later), and pcov needs a fix and release first: krakjoe/pcov#111 The heroku-20 stack is not getting this version because the stack is already deprecated. GUS-W-17226361
There is no more E_STRICT for error_reporting, and session.sid_length is gone. The imap extension has moved to PECL. No blackfire or newrelic extension builds yet with support for 8.4. The phalcon extension is incompatible with 8.4 (they always get new releases some time later), and pcov needs a fix and release first: krakjoe/pcov#111 The heroku-20 stack is not getting this version because the stack is already deprecated. GUS-W-17226361
Is there any update on when this PR is going to get merged? |
No description provided.