Skip to content

Commit

Permalink
Some conversions to use PacketBufferHandle (project-chip#4011)
Browse files Browse the repository at this point in the history
#### Problem

Code should use `PacketBufferHandle` rather than `PacketBuffer *`.

#### Summary of Changes

- Converts send paths and most other remaining code.
- Adds some PacketBufferHandle convenience functions.
- Removes AddToEnd_ForNow() and DetachTail_ForNow().

Part of issue project-chip#2707 - Figure out a way to express PacketBuffer ownership in the type system
  • Loading branch information
kpschoedel committed Dec 1, 2020
1 parent b1139f7 commit 2a0e7a3
Show file tree
Hide file tree
Showing 70 changed files with 487 additions and 636 deletions.
4 changes: 2 additions & 2 deletions examples/minimal-mdns/client.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ void BroadcastPacket(mdns::Minimal::ServerBase * server)
QuerySplitter query;
query.Split(gOptions.query);

mdns::Minimal::QueryBuilder builder(buffer.Get_ForNow());
mdns::Minimal::QueryBuilder builder(buffer.Retain());

builder.Header().SetMessageId(kTestMessageId);
builder.AddQuery(query.MdnsQuery()
Expand All @@ -227,7 +227,7 @@ void BroadcastPacket(mdns::Minimal::ServerBase * server)
return;
}

if (server->BroadcastSend(buffer.Release_ForNow(), gOptions.querySendPort) != CHIP_NO_ERROR)
if (server->BroadcastSend(std::move(buffer), gOptions.querySendPort) != CHIP_NO_ERROR)
{
printf("Error sending\n");
return;
Expand Down
Loading

0 comments on commit 2a0e7a3

Please sign in to comment.